markFeatureWriter: Support contextual ligature anchors #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to be merged after #869 (all commits here except the last are from the other PR). |
khaledhosny
force-pushed
the
contextual-ligature-anchors
branch
from
eb5b8f1
to
930642a
Compare
The current code was assuming all contextual anchors are mark-to-base and was producing wrong output for ligature anchors. With this change, contextual ligature anchors are properly supported.
Instead of raising KeyError trying to access non existing context.
khaledhosny
force-pushed
the
contextual-ligature-anchors
branch
from
930642a
to
9436cd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code was assuming all contextual anchors are mark-to-base and was producing wrong output for ligature anchors. With this change, contextual ligature anchors are properly supported.