Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[featureWriters] Support insert marker in the middle of a feature block #873

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

khaledhosny
Copy link
Collaborator

Split the feature block into two and insert the generated code in the middle.

See #351 (comment)

Split the feature block into two and insert the generated code in the
middle.

See #351 (comment)
@khaledhosny khaledhosny force-pushed the insert-automatic-code-middle branch from 2e9c6ed to ff3f47b Compare September 23, 2024 08:51
@khaledhosny khaledhosny requested a review from madig September 23, 2024 19:03
@khaledhosny
Copy link
Collaborator Author

This does not handle lookupflag, scipt, or language that might be defined in the original feature block (they remain in the first half, while the new block does not get them). @schriftgestalt, what does Glyphs do in this case?

@khaledhosny khaledhosny merged commit 5fd168e into main Sep 24, 2024
9 checks passed
@khaledhosny khaledhosny deleted the insert-automatic-code-middle branch September 24, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants