[cursFeatureWriter] Respect direction suffix when setting lookupflag #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default we set RightToLeft lookupflag for RTL glyphs, which is a sane default. But, despite the flags name, it is not directly related to glyph directionality, rather it defines which glyphs stay at their natural position and which gets shifted. When the flag is set, glyphs to the right gets shifted, otherwise glyphs to the left. GlyphsApp supports controlling the flag by adding `.RTL` or `.LTR` suffix to the anchor names, so we now support this as well. See for examples of this: https://forum.glyphsapp.com/t/is-there-a-solution-for-vertical-kerning-in-arabic-script/26571/39
anthrotype
reviewed
Oct 7, 2024
anthrotype
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we set RightToLeft lookupflag for RTL glyphs, which is a sane default. But, despite the flags name, it is not directly related to glyph directionality, rather it defines which glyphs stay at their natural position and which gets shifted. When the flag is set, glyphs to the right gets shifted, otherwise glyphs to the left.
GlyphsApp supports controlling the flag by adding
.RTLor.LTRsuffix to the anchor names, so we now support this as well.See for examples of this:
https://forum.glyphsapp.com/t/is-there-a-solution-for-vertical-kerning-in-arabic-script/26571/39