Skip to content

Commit

Permalink
Fix sdk-server image make target
Browse files Browse the repository at this point in the history
SDK sidecar image is used to run conformance tests against it.
Fix for make run-sdk-conformance-local in particular.
  • Loading branch information
aLekSer committed Dec 4, 2019
1 parent e458455 commit 12361ef
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion build/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ build-agones-sdk-image: $(ensure-build-image) build-agones-sdk-binary build-lice
docker build $(agones_path)/cmd/sdk-server/ --tag=$(sidecar_tag) $(DOCKER_BUILD_ARGS)

# Build sidecar image only
build-agones-sdk-server-image: $(ensure-build-image) build-agones-sdk-binary-linux
build-agones-sdk-server-image: $(ensure-build-image) build-agones-sdk-binary-linux build-licenses build-required-src-dist
docker build $(agones_path)/cmd/sdk-server/ --tag=$(sidecar_tag) $(DOCKER_BUILD_ARGS)

# Build a static binary for the ping service
Expand Down
2 changes: 1 addition & 1 deletion build/includes/kind.mk
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ kind-install:
IMAGE_PULL_POLICY=IfNotPresent PING_SERVICE_TYPE=NodePort ALLOCATOR_SERVICE_TYPE=NodePort\
KUBECONFIG="$(shell kind get kubeconfig-path --name="$(KIND_PROFILE)")"

# pushses the current dev version of agones to the kind single node cluster.
# pushes the current dev version of agones to the kind single node cluster.
kind-push:
kind load docker-image $(sidecar_tag) --name="$(KIND_PROFILE)"
kind load docker-image $(controller_tag) --name="$(KIND_PROFILE)"
Expand Down

0 comments on commit 12361ef

Please sign in to comment.