Made strategy configurable on relevant deployments

- Updated chart templates and values - Update documentation
googleforgames · Aug 26, 2022 · befd4e8 · befd4e8
1 parent 954e5f1
commit befd4e8
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/install/helm/agones/templates/ping.yaml b/install/helm/agones/templates/ping.yaml
@@ -25,6 +25,10 @@ metadata:
     release: {{ .Release.Name }}
     heritage: {{ .Release.Service }}
 spec:
+{{- if .Values.agones.ping.updateStrategy }}
+  strategy:
+{{- toYaml .Values.agones.ping.updateStrategy | nindent 4}}
+{{- end }}
   selector:
     matchLabels:
       agones.dev/role: ping

diff --git a/install/helm/agones/templates/service/allocation.yaml b/install/helm/agones/templates/service/allocation.yaml
@@ -132,6 +132,10 @@ metadata:
     heritage: {{ .Release.Service }}
 spec:
   replicas: {{ .Values.agones.allocator.replicas }}
+{{- if .Values.agones.allocator.updateStrategy }}
+  strategy:
+{{- toYaml .Values.agones.allocator.updateStrategy | nindent 4}}
+{{- end }}
   selector:
     matchLabels:
       multicluster.agones.dev/role: allocator

diff --git a/install/helm/agones/values.yaml b/install/helm/agones/values.yaml
@@ -95,6 +95,7 @@ agones:
     allocationBatchWaitTime: 500ms
   ping:
     install: true
+    updateStrategy: {}
     resources: {}
       # requests:
       #   cpu: 1
@@ -138,6 +139,8 @@ agones:
       timeoutSeconds: 1
   allocator:
     install: true
+    updateStrategy:
+      type: Recreate
     apiServerQPS: 400
     apiServerQPSBurst: 500
     logLevel: info

diff --git a/site/content/en/docs/Installation/Install Agones/helm.md b/site/content/en/docs/Installation/Install Agones/helm.md
@@ -214,9 +214,11 @@ The following tables lists the configurable parameters of the Agones chart and t
 
 {{% feature publishVersion="1.26.0" %}}
 **New Configuration Features:**
-| Parameter                                                | Description                                                                                                               | Default                |
-| -------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------- | ---------------------- |
-|                                                          |                                                                                                                           |                        |
+| Parameter                                                | Description                                                                                                                         | Default                |
+| -------------------------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------- | ---------------------- |
+| `agones.allocator.updateStrategy`                        | The [strategy](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) to apply to the ping deployment      | `{}`                   |
+| `agones.ping.updateStrategy`                             | The [strategy](https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#strategy) to apply to the allocator deployment | `{}`                   |
+
 {{% /feature %}}
 
 [toleration]: https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/