Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Health Checking Documentation bug - doesn't restart before Ready #1229

Closed
markmandel opened this issue Dec 11, 2019 · 0 comments · Fixed by #1233
Closed

Health Checking Documentation bug - doesn't restart before Ready #1229

markmandel opened this issue Dec 11, 2019 · 0 comments · Fixed by #1233
Assignees
@markmandel
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Milestone
1.3.0

Comments

@markmandel
Copy link
Collaborator

But base on the Health Failure Strategy
1. If any of the GameServer container fails exits before the GameServer moves to Ready then, it is restart as per the restartPolicy (which defaults to “Always”)
I didn't change the restartPolicy and gameserver describe events part didnt print SDK.Ready() complete why the game server didn't restart and only the gameserver in fleet will restart?

Ah, that is a legitimate documentation bug! Nice find! 👍

It should read: If any of the GameServer container exits with an error before the GameServer moves to Ready then, the game server container is restarted as per the restartPolicy (which defaults to “Always”)

And it should also state if the GameServer health check fails at any point, the GameServer is moved to Unhealthy. We should also have a section in here on what happens with Fleets in GameServers when they move to Unhealthy -- which is they get deleted (not restarted, like above), and then recreated. Which is the difference you are seeing.

Originally posted by @markmandel in #1217 (comment)

/assign @markmandel
@markmandel markmandel added kind/bug These are bugs. kind/documentation Documentation for Agones labels Dec 11, 2019
markmandel added a commit to markmandel/agones that referenced this issue Dec 13, 2019
@markmandel
Health Checking: Fix doc errors and expand
e351e4b 
There was an erroneous statement in the documentation on how health
checking and process exit would impact if a GameServer would become
Unhealthy. This commit fixes this issue.

This also adds a section on how Unhealthy GameServers are handled when
in a Fleet vs when there are individually created.

Closes googleforgames#1229
@markmandel markmandel mentioned this issue Dec 13, 2019
Merged
markmandel added a commit to markmandel/agones that referenced this issue Dec 20, 2019
@markmandel
Health Checking: Fix doc errors and expand
8a5f3ba 
There was an erroneous statement in the documentation on how health
checking and process exit would impact if a GameServer would become
Unhealthy. This commit fixes this issue.

This also adds a section on how Unhealthy GameServers are handled when
in a Fleet vs when there are individually created.

Closes googleforgames#1229
roberthbailey pushed a commit that referenced this issue Dec 21, 2019
@markmandel @roberthbailey
Health Checking: Fix doc errors and expand (#1233)
fe27cf2 
There was an erroneous statement in the documentation on how health
checking and process exit would impact if a GameServer would become
Unhealthy. This commit fixes this issue.

This also adds a section on how Unhealthy GameServers are handled when
in a Fleet vs when there are individually created.

Closes #1229
@markmandel markmandel added this to the 1.3.0 milestone Jan 10, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this issue Oct 23, 2020
@markmandel @ilkercelikyilmaz
Health Checking: Fix doc errors and expand (googleforgames#1233)
94e864f 
There was an erroneous statement in the documentation on how health
checking and process exit would impact if a GameServer would become
Unhealthy. This commit fixes this issue.

This also adds a section on how Unhealthy GameServers are handled when
in a Fleet vs when there are individually created.

Closes googleforgames#1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markmandel markmandel

Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

Health Checking: Fix doc errors and expand markmandel/agones
1 participant
@markmandel