Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocator throttled by default K8s Client requests per second #1852

Closed
markmandel opened this issue Oct 19, 2020 · 1 comment · Fixed by #1863
Closed

Allocator throttled by default K8s Client requests per second #1852

markmandel opened this issue Oct 19, 2020 · 1 comment · Fixed by #1863
Assignees
Labels
area/performance Anything to do with Agones being slow, or making it go faster. kind/bug These are bugs.
Milestone

Comments

@markmandel
Copy link
Collaborator

What happened:

Allocation through the Allocator gRPC service is showing far lower performance than what was previously tested through a GameServerAllocation directly through the Kubernetes API. (#804 showed 80-160 QPS)

Instead this is showing 4-6 QPS, which is far lower

What you expected to happen:

Similar QPS as directly calling a GameServerAllocation when creating allocations through the gRPC API.

How to reproduce it (as minimally and precisely as possible):

https://github.com/googleforgames/agones/tree/master/test/load/locust-files

Anything else we need to know?:

I think I have a likely culprit for the slowdown through gRPC.

Through the controller we set the QPS and Burst values: https://github.com/googleforgames/agones/blob/master/cmd/controller/main.go#L137-L138

But we don't do the same thing on the allocator: https://github.com/googleforgames/agones/blob/master/cmd/allocator/main.go#L313-L332

Seems like we need a agones.allocator.apiServerQPSBurst and agones.allocator.apiServerQPSBurst on the Helm chart with similar values that are passed down into the Allocator service.

Environment:

  • Agones version: 1.9.0
  • Kubernetes version (use kubectl version): 1.16.0
  • Cloud provider or hardware configuration: GKE
  • Install method (yaml/helm): helm
  • Troubleshooting guide log(s): N/A
  • Others:
@markmandel markmandel added kind/bug These are bugs. area/performance Anything to do with Agones being slow, or making it go faster. labels Oct 19, 2020
@markmandel
Copy link
Collaborator Author

/assign

markmandel added a commit to markmandel/agones that referenced this issue Oct 22, 2020
Allocation endpoints where throttled to the default ~4qps for a
Kubernetes client.

Matching the controller settings on standard QPS and Burst to allow
higher throughput.

Closes googleforgames#1852
markmandel added a commit to markmandel/agones that referenced this issue Oct 22, 2020
Allocation endpoints where throttled to the default ~4qps for a
Kubernetes client.

Matching the controller settings on standard QPS and Burst to allow
higher throughput.

Closes googleforgames#1852
markmandel added a commit to markmandel/agones that referenced this issue Oct 22, 2020
Allocation endpoints where throttled to the default ~4qps for a
Kubernetes client.

Matching the controller settings on standard QPS and Burst to allow
higher throughput.

Closes googleforgames#1852
markmandel added a commit to markmandel/agones that referenced this issue Oct 27, 2020
Allocation endpoints where throttled to the default ~4qps for a
Kubernetes client.

Matching the controller settings on standard QPS and Burst to allow
higher throughput.

Closes googleforgames#1852
markmandel added a commit to markmandel/agones that referenced this issue Oct 28, 2020
Allocation endpoints where throttled to the default ~4qps for a
Kubernetes client.

Matching the controller settings on standard QPS and Burst to allow
higher throughput.

Closes googleforgames#1852
pooneh-m added a commit that referenced this issue Oct 28, 2020
* Add QPS settings to Allocation endpoints

Allocation endpoints where throttled to the default ~4qps for a
Kubernetes client.

Matching the controller settings on standard QPS and Burst to allow
higher throughput.

Closes #1852

* Review updates.

Co-authored-by: pooneh-m <46979170+pooneh-m@users.noreply.github.com>
@markmandel markmandel added this to the 1.10.0 milestone Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Anything to do with Agones being slow, or making it go faster. kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant