Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default value on website for helm.installTests in helm chart setup value is incorrect #2720

Closed
john-haven opened this issue Aug 26, 2022 · 0 comments · Fixed by #2722
Closed
Assignees
Labels
kind/bug These are bugs.
Milestone

Comments

@john-haven
Copy link
Contributor

What happened:
The default value for the helm.installTests value in the helm chart configuration on the website is incorrect - it should be false
https://agones.dev/site/docs/installation/install-agones/helm/#configuration
It looks like a simple copy-paste error.

What you expected to happen:
The value should be changed to false.

How to reproduce it (as minimally and precisely as possible):
Visit the website.

Anything else we need to know?:
The offending line:
https://github.com/googleforgames/agones/blob/release-1.25.0/site/content/en/docs/Installation/Install%20Agones/helm.md?plain=1#L212
The actual default (false) value from the chart:
https://github.com/googleforgames/agones/blob/release-1.25.0/install/helm/agones/values.yaml#L232

Environment:

  • Agones version: 1.25
  • Kubernetes version (use kubectl version): 1.22
  • Cloud provider or hardware configuration: GKE
  • Install method (yaml/helm): helm
  • Troubleshooting guide log(s): n/a
  • Others: n/a
@john-haven john-haven added the kind/bug These are bugs. label Aug 26, 2022
@john-haven john-haven changed the title Default value for helm.installTests in helm chart setup value is incorrect Default value on website for helm.installTests in helm chart setup value is incorrect Aug 26, 2022
@roberthbailey roberthbailey self-assigned this Aug 27, 2022
@SaitejaTamma SaitejaTamma added this to the 1.26.0 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants