Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default value for helm.installTests in the documentation. #2722

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2720

Special notes for your reviewer:
@john-haven

@roberthbailey roberthbailey added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Aug 27, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fb8091fd-53b3-408f-9f6e-657992005478

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2722/head:pr_2722 && git checkout pr_2722
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-4cd4f3b-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4337c3c2-ced8-4113-9319-bb364290e1d9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2722/head:pr_2722 && git checkout pr_2722
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-3852947-amd64

@roberthbailey roberthbailey merged commit e821122 into googleforgames:main Aug 30, 2022
@SaitejaTamma SaitejaTamma added this to the 1.26.0 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default value on website for helm.installTests in helm chart setup value is incorrect
4 participants