Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we rebase images from alpine to gcr.io/distroless/static ? #909

Closed
roberthbailey opened this issue Jul 15, 2019 · 8 comments · Fixed by #3276 or #3277
Closed

Should we rebase images from alpine to gcr.io/distroless/static ? #909

roberthbailey opened this issue Jul 15, 2019 · 8 comments · Fixed by #3276 or #3277
Assignees
@markmandel
Labels
area/operations Installation, updating, metrics etc awaiting-maintainer Block issues from being stale/obsolete/closed good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones

Comments

@roberthbailey
Copy link
Member

Kubernetes has moved to using gcr.io/distroless/static for most base images (see https://github.com/kubernetes/enhancements/blob/master/keps/sig-release/20190316-rebase-images-to-distroless.md#implementation-history). We should investigate whether it makes sense to move from alpine to gcr.io/distroless/static for Agones.
@roberthbailey roberthbailey added the kind/feature New features for Agones label Jul 15, 2019
@markmandel markmandel added the area/operations Installation, updating, metrics etc label Jul 15, 2019
@roberthbailey roberthbailey mentioned this issue Jul 16, 2019
Closed
5 tasks
@roberthbailey roberthbailey changed the title Rebase images from alpine to gcr.io/distroless/static Should we rebase images from alpine to gcr.io/distroless/static ? Jul 25, 2019
@aLekSer aLekSer mentioned this issue Feb 5, 2020
Closed
10 tasks
@markmandel markmandel added the help wanted We would love help on these issues. Please come help us! label Jan 12, 2021
@markmandel
Copy link
Collaborator

markmandel commented Jan 12, 2021 •
edited
Loading

Going through old issues 😄

https://github.com/GoogleContainerTools/distroless/blob/master/base/README.md

Looks like we should be able to switch straight to gcr.io/distroless/static without any issue.

If we do go this route, we should probably refresh the gcr.io/distroless/static image on each release as part of the do-release Make process, to ensure we have the latest image.

@markmandel markmandel mentioned this issue Apr 13, 2021
Closed
@roberthbailey roberthbailey added the good first issue These are great first issues. If you are looking for a place to start, start here! label Dec 21, 2022
@github-actions
Copy link

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label Apr 15, 2023
@markmandel
Copy link
Collaborator

I'd like to return to this one day. Distroless is very much the "google way" - so at some point we should probably move over.

@markmandel markmandel removed the stale Pending closure unless there is a strong objection. label Apr 15, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

'This issue is marked as Stale due to inactivity for more than 30 days. To avoid being marked as 'stale' please add 'awaiting-maintainer' label or add a comment. Thank you for your contributions '

@github-actions github-actions bot added the stale Pending closure unless there is a strong objection. label Jun 1, 2023
@roberthbailey
Copy link
Member Author

@igooch - FYI

@markmandel markmandel added awaiting-maintainer Block issues from being stale/obsolete/closed and removed stale Pending closure unless there is a strong objection. labels Jun 7, 2023
@markmandel
Copy link
Collaborator

I'm shifting this to "awaiting-maintainer" - I think we should do it.

@aimuz
Copy link
Collaborator

aimuz commented Jun 8, 2023

I have time for this.

@markmandel markmandel self-assigned this Jul 14, 2023
@markmandel
Copy link
Collaborator

Starting on this right now - Alphin 3.14 stopped getting security updates in May, so seemed like a good time to make the change across the board.

markmandel added a commit to markmandel/agones that referenced this issue Jul 17, 2023
@markmandel
SDK done. Worked great. Going to do the rest and test.
48935d3 
Everyting is working except for extensions!
We have an installation!

Work on googleforgames#909
markmandel added a commit to markmandel/agones that referenced this issue Jul 17, 2023
@markmandel
Alpine ➡️ Distroless as Agones base image
571552b 
Alpine 3.14 stopped getting security updates back in May of this year,
so we needed to update things anyway. Seemed like a good time to move
over to the Google supported base container image.

Also since we're always building off distroless' latest image, we don't
need to update version numbers to make sure releases always have the
latest version, so we always get ongoing security updates.

Work on googleforgames#909
@markmandel markmandel mentioned this issue Jul 17, 2023
Merged
markmandel added a commit to markmandel/agones that referenced this issue Jul 18, 2023
@markmandel
Alpine ➡️ Distroless as Agones base image
8381d7f 
Alpine 3.14 stopped getting security updates back in May of this year,
so we needed to update things anyway. Seemed like a good time to move
over to the Google supported base container image.

Also since we're always building off distroless' latest image, we don't
need to update version numbers to make sure releases always have the
latest version, so we always get ongoing security updates.

Work on googleforgames#909
gongmax pushed a commit that referenced this issue Jul 18, 2023
@markmandel
Alpine ➡️ Distroless as Agones base image (#3270)
3d57eaa 
Alpine 3.14 stopped getting security updates back in May of this year,
so we needed to update things anyway. Seemed like a good time to move
over to the Google supported base container image.

Also since we're always building off distroless' latest image, we don't
need to update version numbers to make sure releases always have the
latest version, so we always get ongoing security updates.

Work on #909
This was referenced Jul 19, 2023
Merged
Merged
markmandel added a commit to markmandel/agones that referenced this issue Jul 20, 2023
@markmandel
Move simple-game-server to Distroless base
38d1362 
This includes:
* Replacing Alpine with Distroless as the base image
* Tweaked the creation of the mulit-arch image manifest to use a more
recent command (something changed in Docker 24.0.4 that broke the
current setup, also this is less steps).
* Updated all the reference to simple-game-server:0.16 to
simple-game-server:0.17.

Work on googleforgames#909
markmandel added a commit to markmandel/agones that referenced this issue Jul 20, 2023
@markmandel
Move simple-game-server to Distroless base
490587a 
This includes:
* Replacing Alpine with Distroless as the base image
* Tweaked the creation of the mulit-arch image manifest to use a more
recent command (something changed in Docker 24.0.4 that broke the
current setup, also this is less steps).
* Updated all the reference to simple-game-server:0.16 to
simple-game-server:0.17.

Work on googleforgames#909
@markmandel markmandel mentioned this issue Jul 20, 2023
Merged
markmandel added a commit to markmandel/agones that referenced this issue Jul 20, 2023
@markmandel
Move simple-game-server to Distroless base
d47ddbd 
This includes:
* Replacing Alpine with Distroless as the base image
* Tweaked the creation of the mulit-arch image manifest to use a more
recent command (something changed in Docker 24.0.4 that broke the
current setup, also this is less steps).
* Updated all the reference to simple-game-server:0.16 to
simple-game-server:0.17.

Work on googleforgames#909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markmandel markmandel

Labels
area/operations Installation, updating, metrics etc awaiting-maintainer Block issues from being stale/obsolete/closed good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! kind/feature New features for Agones
Projects
None yet
Milestone
No milestone
3 participants
@markmandel @roberthbailey @aimuz