Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky: TestControllerApplyGameServerAddressAndPort #1002

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Flaky: TestControllerApplyGameServerAddressAndPort #1002

merged 2 commits into from
Aug 15, 2019

Conversation

markmandel
Copy link
Collaborator

Run 100 times, doesn't fail anymore.

@markmandel
Flaky: TestControllerApplyGameServerAddressAndPort
cdadd62 
Run 100 times, doesn't fail anymore.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Aug 15, 2019
@markmandel markmandel mentioned this pull request Aug 15, 2019
Merged
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6e223013-3f17-4aa9-ab23-1b7efc1321b0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1002/head:pr_1002 && git checkout pr_1002
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-cdadd62

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a541916a-7aee-4785-a32c-80db7d319a31

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1002/head:pr_1002 && git checkout pr_1002
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-983f7f4

@markmandel markmandel merged commit dce1546 into googleforgames:master Aug 15, 2019
@markmandel markmandel added this to the 1.0 milestone Aug 15, 2019
@markmandel markmandel deleted the flaky/TestControllerApplyGameServerAddressAndPort branch August 15, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees
No one assigned
Labels
area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@markmandel @agones-bot @roberthbailey