Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding namespace for multi-cluster allocation policy #1052

Merged
merged 1 commit into from
Sep 21, 2019
Merged

Adding namespace for multi-cluster allocation policy #1052

merged 1 commit into from
Sep 21, 2019

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Sep 10, 2019 •
edited
Loading

Addressing: #980

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b7715bf0-762d-4962-814f-16ee73bcd02f

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4599f622-43c2-46f4-ba2a-c1137642cc02

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@pooneh-m pooneh-m requested a review from markmandel September 10, 2019 17:34
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3c403271-ff7b-4bb0-917e-5dd9d1f7e77c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1052/head:pr_1052 && git checkout pr_1052
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.0.0-2532354

@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 10, 2019
@markmandel markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 17, 2019
roberthbailey
roberthbailey reviewed Sep 19, 2019
View reviewed changes
pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go Outdated Show resolved Hide resolved
pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go Outdated
SecretName string `json:"secretName"`
// The name of the secret that contains TLS client certificates to connect the allocator server in the targeted cluster
SecretName string `json:"secretName"`
// the cluster namespace to allocate gameserver from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: start comment with a capital.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another nit: I think it's a bit more proper to phrase it as "The cluster namespace from which to allocate gameservers" since ending sentences with 'from' or 'to' leaves the reading thinking you forgot to type the rest of it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the suggestion.

@roberthbailey roberthbailey self-assigned this Sep 19, 2019
pooneh-m
pooneh-m commented Sep 20, 2019
View reviewed changes
Copy link
Contributor Author

@pooneh-m pooneh-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review.

pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go Outdated Show resolved Hide resolved
pkg/apis/multicluster/v1alpha1/gameserverallocationpolicy.go Outdated
SecretName string `json:"secretName"`
// The name of the secret that contains TLS client certificates to connect the allocator server in the targeted cluster
SecretName string `json:"secretName"`
// the cluster namespace to allocate gameserver from
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the suggestion.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Member

/assign

@pooneh-m pooneh-m removed the request for review from markmandel September 20, 2019 18:44
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b7f9dc2f-a76f-46be-9997-e9c6c0eb109a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7eba26ab-daa7-45e1-9b82-a7de254d9eae

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c6f34238-42ba-43de-85d7-cc4f0d1499e8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1052/head:pr_1052 && git checkout pr_1052
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-72dfc78

@pooneh-m pooneh-m merged commit 69edb8b into googleforgames:master Sep 21, 2019
@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added the kind/feature New features for Agones label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees

@roberthbailey roberthbailey

Labels
kind/feature New features for Agones lgtm size/S
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pooneh-m @agones-bot @google-oss-robot @roberthbailey @markmandel