Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the API for allocator to allocation.proto #1123

Merged
merged 1 commit into from
Oct 17, 2019

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Oct 17, 2019

No description provided.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 57f6a17a-1475-4d3f-b229-79ed97572e63

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1123/head:pr_1123 && git checkout pr_1123
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-32b38ab

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 61be19ac-582d-44a8-b783-c0a0516b02e0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1123/head:pr_1123 && git checkout pr_1123
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-b131037

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Member

I'm marking this as a breaking change, since it's changing the API surface for the allocator. Since this is still an alpha feature that's ok, but I think it'll help craft the release notes for 1.1 (so that anyone using this feature will be made aware).

@roberthbailey roberthbailey merged commit b22140a into googleforgames:master Oct 17, 2019
@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added the kind/feature New features for Agones label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/breaking Breaking change kind/feature New features for Agones lgtm size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants