Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the default ports used by the sdkserver sidecar on the website #1210

Merged

Conversation

roberthbailey
Copy link
Member

/assign @markmandel

@roberthbailey roberthbailey force-pushed the default-sdkserver-port-docs branch from 07d3538 to 32d16a6 Compare December 5, 2019 18:09
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2beca587-50df-46a4-854b-d1e97b5ac1e1

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator

Some new flakiness:

time="2019-12-05 18:21:51.131" level=info msg="Finished cleanup."
--- FAIL: TestAllocator (0.79s)
    allocator_test.go:62: deleting pods failed: pods "agones-allocator-68dc6b7867-zsnll" not found
--- FAIL: TestAllocatorCrossNamespace (2.91s)
    allocator_test.go:128: Allocator TLS is refreshed with public CA: -----BEGIN CERTIFICATE-----
        MIIDMTCCAhmgAwIBAgIQFvlwFH0J+UZqMR9o7katazANBgkqhkiG9w0BAQUFADAq
        MRAwDgYDVQQKEwd0ZXN0aW5nMRYwFAYDVQQDEw0zNC44Mi4xMDIuMjMyMB4XDTE5
        MTIwNTE4MjE1MloXDTE5MTIwNTE5MjE1MlowKjEQMA4GA1UEChMHdGVzdGluZzEW
        MBQGA1UEAxMNMzQuODIuMTAyLjIzMjCCASIwDQYJKoZIhvcNAQEBBQADggEPADCC
        AQoCggEBAMGVgVqkC7aG8qP++Wv0QBsd5oOR/hQ11xVY4+XGA1ATo8vOveM/sGjK
        zU3/b5Z/QdgH1Zj43QeKfxSnMrKfk4uHeY7YmOQse9JEv5bRhoNXwRwd7H5FqNV0
        Vp+H828rwbSf5jgWzJlR4kpbX4NAZb/6aZLdNZuL08/shbJ3UZ+1vGT906D71C1t
        fR5VOrFX3MAQJB+Z5o53Pj+neGGl1UFul7ev6mgIXmgTgYGLb5CdEbrT7OmTPDqn
        NNf2atS+NnDDbEnm3s8DtrLTyaeM2+nPjAXf8FC94Bh7m2jI/kfzklyls9pA//XW
        Di+LpGef3f9zGq3eZKEtII7Fr8Hm3q8CAwEAAaNTMFEwDgYDVR0PAQH/BAQDAgKk
        MB0GA1UdJQQWMBQGCCsGAQUFBwMCBggrBgEFBQcDATAPBgNVHRMBAf8EBTADAQH/
        MA8GA1UdEQQIMAaHBCJSZugwDQYJKoZIhvcNAQEFBQADggEBABlvYNamSSU6P+Km
        lRPitFn2iAxu4K4ZA2V9OHLqQk07ChDKnph6XqqDBD8M7pF5UxsJcPolMkuEICRq
        4BvsyvPyaeJFZRkc2z6sExo1ea5SXIlKSpF7KtypfzD6yTiECnk108l6AWkMw5me
        lCEWu8Ew3sbB22PCPuglhS/82IlP6AHAQ/hnr1F4LOAznPwrQw9e5Y+b1ucsaLnP
        41wdH9JwD73j4yK4ig9BBsUi3wgJZ1MOaH33YpJAJ03Hgimpw96/PeCs7Asl/lG3
        Klfv+/Xo1bAP11CzvFPZKDo6nRJO+ETa4FH5elzLpyPUdQbJRcc2uDVNN9iUc4Ha
        7nJRNSg=
        -----END CERTIFICATE-----
         for endpoint 34.82.102.232
    allocator_test.go:129: deleting pods failed: pods "agones-allocator-64447cfc57-hpzdd" not found

/cc @pooneh-m for visibility.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 98872f07-35fd-4d6d-adfe-d9c4cedca253

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1210/head:pr_1210 && git checkout pr_1210
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-32d16a6

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel markmandel added kind/documentation Documentation for Agones kind/feature New features for Agones labels Dec 5, 2019
@markmandel markmandel merged commit 8c2c068 into googleforgames:master Dec 5, 2019
@markmandel markmandel added this to the 1.2.0 milestone Dec 10, 2019
@roberthbailey roberthbailey deleted the default-sdkserver-port-docs branch August 24, 2020 23:01
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/documentation Documentation for Agones kind/feature New features for Agones lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants