Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more details on Allocate() behaviour #1346

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Add more details on Allocate() behaviour #1346

merged 1 commit into from
Feb 18, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Feb 18, 2020

There was lack of details what is the result of SDK.Allocate() function
call.

@aLekSer aLekSer changed the title tAdd more details on Allocate() behaviour Add more details on Allocate() behaviour Feb 18, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2784d2bd-6012-47a9-bb9c-9d41ed90105f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1346/head:pr_1346 && git checkout pr_1346
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-204234e

@markmandel
Copy link
Collaborator

This is actually true for all setting functions in the SDK - should we make this a higher level comment in the docs (i.e. cover all mutation methods) - rather than make it specific to Allocate?

@aLekSer
Copy link
Collaborator Author

aLekSer commented Feb 18, 2020 •
edited
Loading

Well, I also thought about that, I think we should move it higher. And for Allocate just point, so that it is not skipped. Because Allocate "pins" GameServer not to be deleted more than other states.

@KamiMay
Copy link

KamiMay commented Feb 18, 2020

This explains why we had issues using this SDK to allocate servers. We ended up reverting back to our original way of allocation.

markmandel
markmandel reviewed Feb 18, 2020
View reviewed changes
site/content/en/docs/Guides/Client SDKs/_index.md Outdated
For those scenarios, this SDK functionality exists.
For those scenarios, this SDK functionality exists.

Calling `Allocate()` function does not guarantee that GameServer becomes `Allocated` after this call. For instance, it could be moved to the `Shutdown` state elsewhere (for example when fleet scales down). You can verify the result of this call by waiting for the `Allocated` Status in GameServer() function output.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would actually advocate using Watch() to react to when the Allocation actually happens, rather than using GameServer() (polling the GameServer doesn't hurt, since it's cached locally, but Watch would be better)

@markmandel
Copy link
Collaborator

Well, I also thought about that, I think we should move it higher. And for Allocate just point, so that it is not skipped. Because Allocate "pins" GameServer not to be deleted more than other states.

Yeah that makes sense - so basically, do both? I'm down for both.

@aLekSer
Add more details on Allocate() behaviour
7708faf 
There was lack of details what is the result of SDK.Allocate() function
call.
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: d60e0fe2-7152-433a-b76e-bd36de722e6a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1f513119-9ebf-4bf6-8cb1-32524775f68b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1346/head:pr_1346 && git checkout pr_1346
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-7708faf

markmandel
markmandel approved these changes Feb 18, 2020
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@markmandel markmandel merged commit 8c7fa70 into googleforgames:master Feb 18, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer deleted the docs/sdk-allocate branch February 19, 2020 08:46
@markmandel markmandel added this to the 1.4.0 milestone Feb 26, 2020
@markmandel markmandel added kind/documentation Documentation for Agones kind/cleanup Refactoring code, fixing up documentation, etc labels Feb 26, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @ilkercelikyilmaz
Add more details on Allocate() behaviour (googleforgames#1346)
9081c83 
There was lack of details what is the result of SDK.Allocate() function
call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@markmandel markmandel

Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc kind/documentation Documentation for Agones lgtm size/S
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@aLekSer @agones-bot @markmandel @KamiMay @google-oss-robot