Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated documentation for multi-cluster allocation #1363

Closed
wants to merge 1 commit into from
Closed

Updated documentation for multi-cluster allocation #1363

wants to merge 1 commit into from

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Feb 25, 2020 •
edited
Loading

Closes #1301
Closes #1333

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pooneh-m pooneh-m closed this Feb 25, 2020
@pooneh-m pooneh-m requested review from markmandel and removed request for cyriltovena and EricFortin February 25, 2020 18:37
@pooneh-m pooneh-m reopened this Feb 25, 2020
@pooneh-m pooneh-m marked this pull request as ready for review February 25, 2020 18:40
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4a838521-94df-4789-9871-388406a3751b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

drichardson
drichardson suggested changes Feb 25, 2020
View reviewed changes
site/content/en/docs/Advanced/multi-cluster-allocation.md
@@ -96,7 +96,7 @@ To enable multi-cluster allocation, set `multiClusterSetting.enabled` to `true`
NAMESPACE=<namespace>
FLEET_NAME=<fleet name>

curl https://${EXTERNAL_IP}:443/v1alpha/gameserverallocation \
curl --http2 https://${EXTERNAL_IP}:443/v1alpha/gameserverallocation \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change the v1alpha to v1alpha1 due to my mistake in PR #1361.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This has also more work to get the gRPC working.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't reopen this PR again; so I opened a new PR: #1365.
@drichardson thanks again for finding the error. Please let me know if you have any other feedback on the new PR.

@google-oss-robot
Copy link

@drichardson: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 28689b33-22a3-4540-b8c7-712a0a70c8be

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1363/head:pr_1363 && git checkout pr_1363
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-4a8cf1a

@pooneh-m pooneh-m closed this Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drichardson drichardson drichardson requested changes

@markmandel markmandel Awaiting requested review from markmandel

Assignees
No one assigned
Labels
approved size/M
Projects
None yet
Milestone
No milestone
4 participants
@pooneh-m @google-oss-robot @agones-bot @drichardson