Documented an approach of log levels usage #1368

akremsa · 2020-02-27T11:06:01Z

This PR is related to #1223

agones-bot · 2020-02-27T11:23:49Z

Build Succeeded 👏

Build Id: 8868e4e0-a3b1-4efe-86d8-1784c6229931

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-ce43a23
image: gcr.io/agones-images/agones-sdk:1.4.0-ce43a23
image: gcr.io/agones-images/agones-ping:1.4.0-ce43a23
Linux C++ SDK (build): agonessdk-1.4.0-ce43a23-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-ce43a23.zip

A preview of the website (the last 30 builds are retained):

https://ce43a23-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1368/head:pr_1368 && git checkout pr_1368
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-ce43a23

agones-bot · 2020-02-28T13:41:34Z

Build Failed 😱

Build Id: 44b634fe-2a8f-4c9c-9aae-73f9e6dc5482

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

CONTRIBUTING.md

agones-bot · 2020-02-28T15:25:51Z

Build Succeeded 👏

Build Id: 50385723-a2b8-43a4-8f07-d11cd7ad81c8

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-5484ebb
image: gcr.io/agones-images/agones-sdk:1.4.0-5484ebb
image: gcr.io/agones-images/agones-ping:1.4.0-5484ebb
Linux C++ SDK (build): agonessdk-1.4.0-5484ebb-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-5484ebb.zip

A preview of the website (the last 30 builds are retained):

https://5484ebb-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1368/head:pr_1368 && git checkout pr_1368
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-5484ebb

agones-bot · 2020-03-01T13:37:44Z

Build Failed 😱

Build Id: 52648e76-f2c4-4f54-b451-ee72e9a95b8d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-02T09:52:49Z

Build Succeeded 👏

Build Id: 5d241656-8b4e-4a88-a5b9-e13662664557

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-8285cf5
image: gcr.io/agones-images/agones-sdk:1.4.0-8285cf5
image: gcr.io/agones-images/agones-ping:1.4.0-8285cf5
Linux C++ SDK (build): agonessdk-1.4.0-8285cf5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-8285cf5.zip

A preview of the website (the last 30 builds are retained):

https://8285cf5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1368/head:pr_1368 && git checkout pr_1368
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-8285cf5

aLekSer

Thanks for putting this together and applying comments

akremsa · 2020-03-02T16:57:59Z

/assign @roberthbailey

markmandel

Since this is an almost direct copy/paste from https://reflectoring.io/logging-levels/ - let's credit the article with providing the foundation.

fixes fix

akremsa · 2020-03-02T17:49:31Z

Since this is an almost direct copy/paste from https://reflectoring.io/logging-levels/ - let's credit the article with providing the foundation.

Done

agones-bot · 2020-03-02T18:06:56Z

Build Succeeded 👏

Build Id: 1aa2b1c1-2ddf-41c4-80ac-5f7e13ceb328

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-97bad0e
image: gcr.io/agones-images/agones-sdk:1.4.0-97bad0e
image: gcr.io/agones-images/agones-ping:1.4.0-97bad0e
Linux C++ SDK (build): agonessdk-1.4.0-97bad0e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-97bad0e.zip

A preview of the website (the last 30 builds are retained):

https://97bad0e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1368/head:pr_1368 && git checkout pr_1368
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-97bad0e

markmandel

Nice stuff 👍

google-oss-robot · 2020-03-03T00:46:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-03-03T00:46:54Z

New changes are detected. LGTM label has been removed.

agones-bot · 2020-03-03T01:01:50Z

Build Failed 😱

Build Id: 60b590b2-da35-4e96-adca-1ce237289193

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-03-03T01:19:31Z

Build Succeeded 👏

Build Id: 2353984f-0868-4657-9123-c677f67c55d6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.4.0-e9be7ce
image: gcr.io/agones-images/agones-sdk:1.4.0-e9be7ce
image: gcr.io/agones-images/agones-ping:1.4.0-e9be7ce
Linux C++ SDK (build): agonessdk-1.4.0-e9be7ce-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.4.0-e9be7ce.zip

A preview of the website (the last 30 builds are retained):

https://e9be7ce-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1368/head:pr_1368 && git checkout pr_1368
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.4.0-e9be7ce

fixes fix Co-authored-by: Mark Mandel <mark.mandel@gmail.com>

google-oss-robot requested review from dzlier-gcp and EricFortin February 27, 2020 11:06

google-oss-robot added the size/XS label Feb 27, 2020

google-oss-robot assigned aLekSer Feb 27, 2020

aLekSer self-requested a review February 27, 2020 12:06

akremsa force-pushed the log-lvls-doc branch from ce43a23 to 60a114c Compare February 28, 2020 13:31

aLekSer suggested changes Feb 28, 2020

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

aLekSer reviewed Feb 28, 2020

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

aLekSer reviewed Feb 28, 2020

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

akremsa force-pushed the log-lvls-doc branch from 5484ebb to 427cae7 Compare March 1, 2020 13:23

akremsa requested a review from aLekSer March 1, 2020 13:25

akremsa force-pushed the log-lvls-doc branch from 427cae7 to 8285cf5 Compare March 2, 2020 09:35

aLekSer approved these changes Mar 2, 2020

View reviewed changes

google-oss-robot added the lgtm label Mar 2, 2020

google-oss-robot assigned roberthbailey Mar 2, 2020

markmandel requested changes Mar 2, 2020

View reviewed changes

google-oss-robot assigned markmandel Mar 2, 2020

google-oss-robot removed the lgtm label Mar 2, 2020

Documented an approach of log levels usage

97bad0e

fixes fix

akremsa force-pushed the log-lvls-doc branch from 8285cf5 to 97bad0e Compare March 2, 2020 17:48

akremsa requested a review from markmandel March 2, 2020 17:49

markmandel approved these changes Mar 3, 2020

View reviewed changes

google-oss-robot added the lgtm label Mar 3, 2020

Merge branch 'master' into log-lvls-doc

e9be7ce

google-oss-robot added approved and removed lgtm labels Mar 3, 2020

markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. area/meta Organisational matters. e.g. Governance, release cycles, etc. kind/documentation Documentation for Agones labels Mar 3, 2020

markmandel added this to the 1.4.0 milestone Mar 3, 2020

markmandel merged commit b8ed44d into googleforgames:master Mar 3, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Documented an approach of log levels usage (googleforgames#1368)

e726d11

fixes fix Co-authored-by: Mark Mandel <mark.mandel@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Documented an approach of log levels usage #1368

Documented an approach of log levels usage #1368

akremsa commented Feb 27, 2020

agones-bot commented Feb 27, 2020

agones-bot commented Feb 28, 2020

agones-bot commented Feb 28, 2020

agones-bot commented Mar 1, 2020

agones-bot commented Mar 2, 2020

aLekSer left a comment

akremsa commented Mar 2, 2020

markmandel left a comment

akremsa commented Mar 2, 2020

agones-bot commented Mar 2, 2020

markmandel left a comment

google-oss-robot commented Mar 3, 2020

google-oss-robot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

Documented an approach of log levels usage #1368

Documented an approach of log levels usage #1368

Conversation

akremsa commented Feb 27, 2020

agones-bot commented Feb 27, 2020

agones-bot commented Feb 28, 2020

agones-bot commented Feb 28, 2020

agones-bot commented Mar 1, 2020

agones-bot commented Mar 2, 2020

aLekSer left a comment

Choose a reason for hiding this comment

akremsa commented Mar 2, 2020

markmandel left a comment

Choose a reason for hiding this comment

akremsa commented Mar 2, 2020

agones-bot commented Mar 2, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Mar 3, 2020

google-oss-robot commented Mar 3, 2020

agones-bot commented Mar 3, 2020

agones-bot commented Mar 3, 2020