Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node.js dependencies and fix annoyances #1415

Merged
merged 3 commits into from
Mar 16, 2020
Merged

Update Node.js dependencies and fix annoyances #1415

merged 3 commits into from
Mar 16, 2020

Conversation

steven-supersolid
Copy link
Collaborator

  • Update dependencies
  • Fix bug where a health stream would not close properly and would prevent the event loop from ending
  • Update grpc generation to remove Buffer deprecation warning

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7760b9da-39af-4b13-8232-76e26736d023

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1415/head:pr_1415 && git checkout pr_1415
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-8c83c5f

@steven-supersolid steven-supersolid changed the title Update dependencies and fix annoyances Update Node.js dependencies and fix annoyances Mar 15, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, steven-supersolid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit e7d5a60 into googleforgames:master Mar 16, 2020
@markmandel markmandel added this to the 1.5.0 milestone Apr 7, 2020
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. labels Apr 7, 2020
@steven-supersolid steven-supersolid deleted the nodejs-deps branch April 26, 2020 12:33
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@steven-supersolid @ilkercelikyilmaz
Update Node.js dependencies and fix annoyances (googleforgames#1415)
02058e1 
* Fix health stream not closing properly. Update dependencies
* Fix Buffer deprecation warning
* Update test for fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@roberthbailey roberthbailey

Labels
approved area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XXL
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@steven-supersolid @agones-bot @google-oss-robot @roberthbailey @markmandel