Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDK Conformance test - fix parallel recordRequests #1456

Merged
merged 2 commits into from
Apr 15, 2020
Merged

SDK Conformance test - fix parallel recordRequests #1456

merged 2 commits into from
Apr 15, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented Apr 8, 2020

Add Unit Test to cover the race condition.

Closes #1452 .

@aLekSer
SDK Conformance test - fix parallel recordRequests
bd87ad7 
Add Unit Test to cover the race condition.
@aLekSer aLekSer force-pushed the fix/flaky-sdk-conformance branch from 0ced4be to bd87ad7 Compare April 8, 2020 13:09
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e8ac04aa-7354-4334-aefd-3194c23db55e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1456/head:pr_1456 && git checkout pr_1456
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-bd87ad7

@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Apr 8, 2020
@markmandel
Copy link
Collaborator

Freezing, just because it touches the sdk-server

markmandel
markmandel reviewed Apr 9, 2020
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM, will Approve and merge after feature freeze.

@markmandel markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Apr 14, 2020
markmandel
markmandel approved these changes Apr 15, 2020
View reviewed changes
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be good to get rid of this flake! 😄

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 78c8b2f6-2287-4fdd-9734-ddd4ee98f1de

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1456/head:pr_1456 && git checkout pr_1456
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-19e9a61

@markmandel markmandel merged commit 0a87d99 into googleforgames:master Apr 15, 2020
@markmandel markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Apr 15, 2020
@markmandel markmandel added this to the 1.6.0 milestone Apr 15, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@aLekSer @markmandel @ilkercelikyilmaz
SDK Conformance test - fix parallel recordRequests (googleforgames#1456)
779388c 
Add Unit Test to cover the race condition.

Co-authored-by: Mark Mandel <markmandel@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@markmandel markmandel

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc size/M
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Flaky: SDK conformance tests
4 participants
@aLekSer @agones-bot @markmandel @google-oss-robot