Changes in proto for Player Tracking design update #1481
Conversation
markmandel
added
kind/feature
|
Build Succeeded 👏 Build Id: 66509b1a-78ad-4019-8a63-fececd5710cf The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
proto/sdk/alpha/alpha.proto
Outdated
| // Call when a player has connected. | ||
| rpc PlayerConnect (PlayerId) returns (Empty) { | ||
| // PlayerConnect increases the SDK’s stored player count by one, and appends this playerID to status.players.id. | ||
| // status.players.count and status.players.ids is then set to update to the player count and id list a second from now, unless there is already an update pending, in which case the update joins that batch operation. |
There was a problem hiding this comment.
Nit: this comment is extra-long, should be split.
This includes changes to make PlayerID consistent in casing. Code generation will come in the next PR to make things easier to review. Work on googleforgames#1033
markmandel
force-pushed
the
feature/proto-player-tracking
branch
from
e791c21 to
2942d09
Compare
|
Pushed up a stack of updated documentation - mostly around when one should use the SDK commands or not. PTAL. |
|
Build Succeeded 👏 Build Id: 0821106b-c430-4b2e-a228-78543ae00edb The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
lgtm, but please address @aLekSer's comments before merging.
|
Build Succeeded 👏 Build Id: f5fbd611-0f57-4363-a98b-c3bb1006ecf6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: 7971333b-1b16-401e-8d7e-684923476e21 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This includes changes to make PlayerID consistent in casing. Code generation will come in the next PR to make things easier to review. Work on googleforgames#1033
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This includes changes to make PlayerID consistent in casing.
Which issue(s) this PR fixes:
Work on #1033
Special notes for your reviewer:
Code generation will come in the next PR to make things easier to
review.