Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small typo in comments #1548

Merged
merged 1 commit into from
May 14, 2020

Conversation

aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented May 14, 2020

There was a typos in GameServer term.

One more could be found in proto. This would go into another PR.

// Send a Empty every d Duration to declare that this GameSever is healthy
rpc Health (stream Empty) returns (Empty) {

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: eaba6e7b-3c50-41af-a081-5ddaeae3ccd0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator Author

aLekSer commented May 14, 2020

site/docs/faq/index.html
  hash does not exist --- site/docs/faq/index.html --> /site/docs/guides/client-sdks/rest/#setlabel-key-value
  hash does not exist --- site/docs/faq/index.html --> /site/docs/guides/client-sdks/rest/#setannotation-key-value
  hash does not exist --- site/docs/faq/index.html --> /site/docs/guides/client-sdks/rest/#setlabel-key-value
  hash does not exist --- site/docs/faq/index.html --> /site/docs/guides/client-sdks/rest/#setannotation-key-value
========================================================================
✘✘✘ failed in 949.115641ms
4 errors in 106 documents

@markmandel
Copy link
Collaborator

I've seen that one a few times as well, and I'm not sure why.

Something fails when creating the site somehow?

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer force-pushed the fix/typo-gameserver branch from c92a944 to faa33b9 Compare May 14, 2020 19:45
@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@aLekSer
Copy link
Collaborator Author

aLekSer commented May 14, 2020

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2d46b6c3-be3b-4b7f-968e-254f8f9f875c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1548/head:pr_1548 && git checkout pr_1548
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-faa33b9

@markmandel markmandel merged commit e077fb7 into googleforgames:master May 14, 2020
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label May 14, 2020
@markmandel markmandel added this to the 1.6.0 milestone May 19, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants