Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site: Fix publish issue with date update #1568

Merged
merged 3 commits into from
May 19, 2020
Merged

Site: Fix publish issue with date update #1568

merged 3 commits into from
May 19, 2020

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

The publishDate will default to the date, so when the date is in the future, the entire page won't render, which then breaks links and the website cannot publish from master.

Which issue(s) this PR fixes:
None.

Special notes for your reviewer:
None.

@markmandel
Site: Fix publish issue with date update
c317bb5 
The publishDate will default to the date, so when the date is in the
future, the entire page won't render, which then breaks links and the
website cannot publish.
@markmandel markmandel added kind/bug These are bugs. area/site The website itself - including redirects, styling, search, etc labels May 18, 2020
@markmandel markmandel requested a review from pooneh-m May 18, 2020 21:06
markmandel
markmandel commented May 18, 2020
View reviewed changes
site/content/en/docs/Advanced/allocator-service.md
@@ -1,6 +1,7 @@
---
title: "Allocator Service"
date: 2020-05-19T05:45:05Z
publishDate: 2019-10-25T05:45:05Z
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pooneh-m you'll find this interesting 😄

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 49565b4c-6942-4ef6-aec7-17e0cacf0bb7

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0a60b95b-4773-498b-abdc-cfb5f2022195

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1568/head:pr_1568 && git checkout pr_1568
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-58130a1

@markmandel markmandel added this to the 1.6.0 milestone May 18, 2020
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 432ab51e-b92f-45ba-8699-8b424ff13d8b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1568/head:pr_1568 && git checkout pr_1568
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-fc6edc4

aLekSer
aLekSer approved these changes May 19, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is hard to get that publishDate is actually needed here, probably we can add this into the docs describing website contributions.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer aLekSer merged commit 9646089 into googleforgames:master May 19, 2020
@markmandel markmandel deleted the site/fix-publish-date branch May 19, 2020 15:12
@markmandel
Copy link
Collaborator Author

It is hard to get that publishDate is actually needed here, probably we can add this into the docs describing website contributions.

Also have a TODO to run the site-static target during site-test to confirm that the production site build is tested during CI.

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@markmandel @aLekSer @ilkercelikyilmaz
Site: Fix publish issue with date update (googleforgames#1568)
7dc2e3e 
The publishDate will default to the date, so when the date is in the
future, the entire page won't render, which then breaks links and the
website cannot publish.

Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

@EricFortin EricFortin Awaiting requested review from EricFortin

Assignees

@aLekSer aLekSer

Labels
approved area/site The website itself - including redirects, styling, search, etc kind/bug These are bugs. lgtm size/XS
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @google-oss-robot @aLekSer