Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a note to the contributing docs that joining the mailing list gives access to build logs #1637

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Add a note to the contributing docs that joining the mailing list gives access to build logs #1637

merged 2 commits into from
Jun 22, 2020

Conversation

roberthbailey
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it: Updates the contributing docs, adding info for new contrubitors.

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

aLekSer
aLekSer reviewed Jun 22, 2020
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
aLekSer
aLekSer approved these changes Jun 22, 2020
View reviewed changes
Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for an update. Now it is clear how to get an access.

Left a comment about the link below.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a3f19404-eaa9-48ee-9b5d-40b3a03c23c7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1637/head:pr_1637 && git checkout pr_1637
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-78e2f9f

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 39635120-dcc1-4236-bf96-0594d5f47f5a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1637/head:pr_1637 && git checkout pr_1637
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.7.0-b1f2951

@aLekSer aLekSer merged commit 0135eec into googleforgames:master Jun 22, 2020
@markmandel markmandel added this to the 1.7.0 milestone Jun 30, 2020
@markmandel markmandel added area/meta Organisational matters. e.g. Governance, release cycles, etc. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jun 30, 2020
@roberthbailey roberthbailey deleted the contributing branch August 24, 2020 23:02
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
@roberthbailey @ilkercelikyilmaz
Add a note to the contributing docs that joining the mailing list giv…
1198222 
…es access to build logs (googleforgames#1637)

* Add a note to the contributing docs that joining the mailing
list gives access to build logs.

* Update link to log level blog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aLekSer aLekSer aLekSer approved these changes

@EricFortin EricFortin Awaiting requested review from EricFortin

@markmandel markmandel Awaiting requested review from markmandel

Assignees

@aLekSer aLekSer

Labels
approved area/meta Organisational matters. e.g. Governance, release cycles, etc. area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes size/XS
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
6 participants
@roberthbailey @agones-bot @google-oss-robot @aLekSer @markmandel @googlebot