Add Terraform example for GKE custom VPC deployment #1697

moesy · 2020-07-18T00:11:52Z

What type of PR is this?
/kind documentation
/kind feature

What this PR does / Why we need it:
Adds an example for deploying Agones on a GKE cluster inside a custom VPC and updates associated docs.

Which issue(s) this PR fixes:
Closes #1641

Special notes for your reviewer:
Related to #1695

Update the terraform gke example to accept inputs for custom vpc deployment. Update associated documentation.

agones-bot · 2020-07-18T00:32:23Z

Build Succeeded 👏

Build Id: 476e0249-83ad-4183-9aea-99265b37fddb

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-b996753
image: gcr.io/agones-images/agones-sdk:1.8.0-b996753
image: gcr.io/agones-images/agones-ping:1.8.0-b996753
Linux C++ SDK (build): agonessdk-1.8.0-b996753-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-b996753.zip

A preview of the website (the last 30 builds are retained):

https://b996753-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1697/head:pr_1697 && git checkout pr_1697
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-b996753

site/content/en/docs/Installation/Terraform/gke.md

examples/terraform-submodules/gke/.gitignore

roberthbailey · 2020-07-21T06:08:50Z

/assign

site/content/en/docs/Installation/Terraform/gke.md

markmandel · 2020-08-06T15:00:03Z

A reminder - if you want this to be included in the 1.8.0 release - release candidate is next Tuesday.

agones-bot · 2020-08-11T21:46:59Z

Build Succeeded 👏

Build Id: 5d32ceda-fd35-4a50-81d9-46fab576961f

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-2e9a837
image: gcr.io/agones-images/agones-sdk:1.8.0-2e9a837
image: gcr.io/agones-images/agones-ping:1.8.0-2e9a837
Linux C++ SDK (build): agonessdk-1.8.0-2e9a837-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-2e9a837.zip

A preview of the website (the last 30 builds are retained):

https://2e9a837-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1697/head:pr_1697 && git checkout pr_1697
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-2e9a837

markmandel · 2020-08-25T23:22:26Z

Doing some cleanup. @moesy are you good to wrap this up, or should we close it for now?

moesy · 2020-08-27T06:55:40Z

Hi @markmandel ill wrap this up by tomorrow thanks for removing the freeze flag.

agones-bot · 2020-08-27T07:14:00Z

Build Failed 😱

Build Id: 64f0ec9b-78e8-4182-b779-d7c9211a6876

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-08-27T18:35:56Z

Build Succeeded 👏

Build Id: f820ba74-405a-4cce-8e1b-82a3b62f995b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.9.0-8c89b42
image: gcr.io/agones-images/agones-sdk:1.9.0-8c89b42
image: gcr.io/agones-images/agones-ping:1.9.0-8c89b42
Linux C++ SDK (build): agonessdk-1.9.0-8c89b42-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.9.0-8c89b42.zip

A preview of the website (the last 30 builds are retained):

https://8c89b42-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1697/head:pr_1697 && git checkout pr_1697
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-8c89b42

Provide a minimal example for deploying Agones on GKE in a custom VPC with terraform. Documentation gated until 1.9.0 release.

agones-bot · 2020-08-28T00:58:17Z

Build Succeeded 👏

Build Id: e6663ae9-5d04-4a3f-8143-6a91cf1548ae

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.9.0-44aae3e
image: gcr.io/agones-images/agones-sdk:1.9.0-44aae3e
image: gcr.io/agones-images/agones-ping:1.9.0-44aae3e
Linux C++ SDK (build): agonessdk-1.9.0-44aae3e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.9.0-44aae3e.zip

A preview of the website (the last 30 builds are retained):

https://44aae3e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1697/head:pr_1697 && git checkout pr_1697
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-44aae3e

agones-bot · 2020-08-28T01:08:45Z

Build Succeeded 👏

Build Id: c151c920-cfc6-4e90-a266-9a834d987d8b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.9.0-c77b9d5
image: gcr.io/agones-images/agones-sdk:1.9.0-c77b9d5
image: gcr.io/agones-images/agones-ping:1.9.0-c77b9d5
Linux C++ SDK (build): agonessdk-1.9.0-c77b9d5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.9.0-c77b9d5.zip

A preview of the website (the last 30 builds are retained):

https://c77b9d5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1697/head:pr_1697 && git checkout pr_1697
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-c77b9d5

roberthbailey

Can you update all of the 1.7.0 references to 1.8.0 and remove the .gitignore file from the PR?

roberthbailey · 2020-08-28T05:23:51Z

site/content/en/docs/Installation/Terraform/gke.md

+
+(optionally you can specify the version of Agones you want to use):
+```
+terraform apply -var project="<YOUR_GCP_ProjectID>" [-var agones_version="1.7.0"]


@markmandel - should we add this variable to the release checklist so that it stays up to date?

Hi @roberthbailey , updated!

Document the subnetwork as a configurable parameter. * Gated until 1.9.0 * Updated agones_version references to 1.8.0

agones-bot · 2020-08-28T17:03:56Z

Build Succeeded 👏

Build Id: 77ae0400-08b6-4912-b5b7-9e015634038c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.9.0-6baaa45
image: gcr.io/agones-images/agones-sdk:1.9.0-6baaa45
image: gcr.io/agones-images/agones-ping:1.9.0-6baaa45
Linux C++ SDK (build): agonessdk-1.9.0-6baaa45-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.9.0-6baaa45.zip

A preview of the website (the last 30 builds are retained):

https://6baaa45-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1697/head:pr_1697 && git checkout pr_1697
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-6baaa45

agones-bot · 2020-08-28T17:15:46Z

Build Succeeded 👏

Build Id: 449259ae-61b8-42e1-ad89-c7f4826e1072

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.9.0-b947294
image: gcr.io/agones-images/agones-sdk:1.9.0-b947294
image: gcr.io/agones-images/agones-ping:1.9.0-b947294
Linux C++ SDK (build): agonessdk-1.9.0-b947294-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.9.0-b947294.zip

A preview of the website (the last 30 builds are retained):

https://b947294-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1697/head:pr_1697 && git checkout pr_1697
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-b947294

agones-bot · 2020-08-28T17:33:25Z

Build Failed 😱

Build Id: 184f574f-9282-441e-a1d8-5566525c2b94

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2020-08-28T18:12:08Z

examples/terraform-submodules/gke/module.tf still references 1.7.0 - can you update that file to 1.8.0 as well?

site/content/en/docs/Installation/Terraform/gke.md

agones-bot · 2020-08-29T20:38:19Z

Build Failed 😱

Build Id: 4ad855df-92b7-41a1-9ca3-60a0624655a4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

google-oss-robot · 2020-08-31T04:49:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moesy, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2020-08-31T20:46:07Z

Build Failed 😱

Build Id: 979a2376-4038-4cae-8848-cac684c879fb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-08-31T21:56:14Z

Build Succeeded 👏

Build Id: 89b52869-d28e-4c33-b275-60f4265a14a2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.9.0-ca94ded
image: gcr.io/agones-images/agones-sdk:1.9.0-ca94ded
image: gcr.io/agones-images/agones-ping:1.9.0-ca94ded
Linux C++ SDK (build): agonessdk-1.9.0-ca94ded-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.9.0-ca94ded.zip

A preview of the website (the last 30 builds are retained):

https://ca94ded-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1697/head:pr_1697 && git checkout pr_1697
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-ca94ded

) * Add Custom VPC to terraform gke example * Add subnetwork to configurable parameters

moesy added 2 commits July 17, 2020 13:59

Add Custom VPC to terraform gke example

8cb0e31

Update the terraform gke example to accept inputs for custom vpc deployment. Update associated documentation.

Run linter

b996753

google-oss-robot requested review from dzlier-gcp and EricFortin July 18, 2020 00:11

googlebot added the cla: yes label Jul 18, 2020

google-oss-robot added the size/M label Jul 18, 2020

roberthbailey reviewed Jul 21, 2020

View reviewed changes

google-oss-robot assigned roberthbailey Jul 21, 2020

aLekSer reviewed Jul 21, 2020

View reviewed changes

site/content/en/docs/Installation/Terraform/gke.md Outdated Show resolved Hide resolved

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Aug 11, 2020

Merge branch 'master' into terraform-gke-example

2e9a837

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Aug 18, 2020

Merge branch 'master' into terraform-gke-example

8c89b42

Doc Terraform GKE VPC Cluster creation

44aae3e

Provide a minimal example for deploying Agones on GKE in a custom VPC with terraform. Documentation gated until 1.9.0 release.

roberthbailey reviewed Aug 28, 2020

View reviewed changes

Add subnetwork to configurable parameters

b947294

Document the subnetwork as a configurable parameter. * Gated until 1.9.0 * Updated agones_version references to 1.8.0

moesy force-pushed the terraform-gke-example branch from 6baaa45 to b947294 Compare August 28, 2020 16:55

Merge branch 'master' into terraform-gke-example

9bf29bb

markmandel reviewed Aug 28, 2020

View reviewed changes

site/content/en/docs/Installation/Terraform/gke.md Outdated Show resolved Hide resolved

Update version ref 1.7.0 -> 1.8.0

ca94ded

roberthbailey approved these changes Aug 31, 2020

View reviewed changes

google-oss-robot added the lgtm label Aug 31, 2020

google-oss-robot added the approved label Aug 31, 2020

markmandel added this to the 1.9.0 milestone Aug 31, 2020

markmandel merged commit 127e26a into googleforgames:master Aug 31, 2020

markmandel added area/examples Examples. Usually found in the `examples` directory kind/feature New features for Agones labels Sep 22, 2020

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Add Terraform example for GKE custom VPC deployment (googleforgames#1697

a60708f

) * Add Custom VPC to terraform gke example * Add subnetwork to configurable parameters

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Terraform example for GKE custom VPC deployment #1697

Add Terraform example for GKE custom VPC deployment #1697

moesy commented Jul 18, 2020

agones-bot commented Jul 18, 2020

roberthbailey commented Jul 21, 2020

markmandel commented Aug 6, 2020

agones-bot commented Aug 11, 2020

markmandel commented Aug 25, 2020

moesy commented Aug 27, 2020

agones-bot commented Aug 27, 2020

agones-bot commented Aug 27, 2020

agones-bot commented Aug 28, 2020

agones-bot commented Aug 28, 2020

roberthbailey left a comment

roberthbailey Aug 28, 2020

moesy Aug 28, 2020

agones-bot commented Aug 28, 2020

agones-bot commented Aug 28, 2020

agones-bot commented Aug 28, 2020

roberthbailey commented Aug 28, 2020

agones-bot commented Aug 29, 2020

google-oss-robot commented Aug 31, 2020

agones-bot commented Aug 31, 2020

agones-bot commented Aug 31, 2020

Add Terraform example for GKE custom VPC deployment #1697

Add Terraform example for GKE custom VPC deployment #1697

Conversation

moesy commented Jul 18, 2020

agones-bot commented Jul 18, 2020

roberthbailey commented Jul 21, 2020

markmandel commented Aug 6, 2020

agones-bot commented Aug 11, 2020

markmandel commented Aug 25, 2020

moesy commented Aug 27, 2020

agones-bot commented Aug 27, 2020

agones-bot commented Aug 27, 2020

agones-bot commented Aug 28, 2020

agones-bot commented Aug 28, 2020

roberthbailey left a comment

Choose a reason for hiding this comment

roberthbailey Aug 28, 2020

Choose a reason for hiding this comment

moesy Aug 28, 2020

Choose a reason for hiding this comment

agones-bot commented Aug 28, 2020

agones-bot commented Aug 28, 2020

agones-bot commented Aug 28, 2020

roberthbailey commented Aug 28, 2020

agones-bot commented Aug 29, 2020

google-oss-robot commented Aug 31, 2020

agones-bot commented Aug 31, 2020

agones-bot commented Aug 31, 2020