Website fix - OpenSSL Switch from master branch to more specific tag v1.1.1 #1716

aLekSer · 2020-07-24T12:06:52Z

Fix all hidden errors on CI, caused by not working htmltest:

A page with status 404 on github.
Hash does not exist error after switch to a new Hugo version:

#setlabelkey-value if it contain a comma. Or without any dashes in the other case.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Merge before #1715 .
For #1712.

Special notes for your reviewer:

agones-bot · 2020-07-24T12:39:14Z

Build Succeeded 👏

Build Id: fe0baa58-1511-4b04-b06c-5b1716e88088

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-aba1b8d
image: gcr.io/agones-images/agones-sdk:1.8.0-aba1b8d
image: gcr.io/agones-images/agones-ping:1.8.0-aba1b8d
Linux C++ SDK (build): agonessdk-1.8.0-aba1b8d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-aba1b8d.zip

A preview of the website (the last 30 builds are retained):

https://aba1b8d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1716/head:pr_1716 && git checkout pr_1716
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-aba1b8d

Fix a hidden error, caused by not working htmltest.

Links with # watch-gameserver becomes # watchgameserver. After Hugo update.

aLekSer · 2020-07-24T15:03:18Z

Htmltest should not contain any hash does not exist now. Please take a look on Step 17 tests. Now it's ready to be merged:

Total in 1914 ms
make[2]: Leaving directory '/workspace/build'
for i in 1 2 3 4 5; \
	do echo "Html Test: Attempt $i" && \
	  docker run --rm -t -e "TERM=xterm-256color" -v /workspace/build//.config/gcloud:/root/.config/gcloud -v ~/.kube/:/root/.kube -v ~/.config/helm:/root/.config/helm -v ~/.cache/helm:/root/.cache/helm -v /workspace:/go/src/agones.dev/agones -v /workspace/build//.gomod:/go/pkg/mod -v /workspace/build//.gocache:/root/.cache/go-build  agones-build:8f335b4456 bash -c \
		"mkdir -p /tmp/website && cp -r /go/src/agones.dev/agones/site/public /tmp/website/site && htmltest -c /go/src/agones.dev/agones/site/htmltest.yaml /tmp/website" && \
break || sleep 60; done
Html Test: Attempt 1
htmltest started at 03:11:00 on /tmp/website
========================================================================
✔✔✔ passed in 349.462185ms
tested 111 documents
make[1]: Leaving directory '/workspace/build'

agones-bot · 2020-07-24T15:05:06Z

Build Succeeded 👏

Build Id: 81cc541d-6476-44cf-a31e-615d750a05d6

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-7c35af3
image: gcr.io/agones-images/agones-sdk:1.8.0-7c35af3
image: gcr.io/agones-images/agones-ping:1.8.0-7c35af3
Linux C++ SDK (build): agonessdk-1.8.0-7c35af3-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-7c35af3.zip

A preview of the website (the last 30 builds are retained):

https://7c35af3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1716/head:pr_1716 && git checkout pr_1716
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-7c35af3

agones-bot · 2020-07-24T15:20:17Z

Build Succeeded 👏

Build Id: 45d3b1b0-ad9b-4c1a-865b-46324728687e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-3874bab
image: gcr.io/agones-images/agones-sdk:1.8.0-3874bab
image: gcr.io/agones-images/agones-ping:1.8.0-3874bab
Linux C++ SDK (build): agonessdk-1.8.0-3874bab-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-3874bab.zip

A preview of the website (the last 30 builds are retained):

https://3874bab-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1716/head:pr_1716 && git checkout pr_1716
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-3874bab

agones-bot · 2020-07-28T06:08:14Z

Build Succeeded 👏

Build Id: 03213c25-0b5b-4e9c-8c36-13c419265eb9

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-43d75a0
image: gcr.io/agones-images/agones-sdk:1.8.0-43d75a0
image: gcr.io/agones-images/agones-ping:1.8.0-43d75a0
Linux C++ SDK (build): agonessdk-1.8.0-43d75a0-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-43d75a0.zip

A preview of the website (the last 30 builds are retained):

https://43d75a0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1716/head:pr_1716 && git checkout pr_1716
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-43d75a0

aLekSer · 2020-07-28T16:13:52Z

Hello @markmandel this htmltest fail was covered by wrong bash script in website.mk #1715 which would be fixed after this PR.

agones-bot · 2020-07-28T16:36:44Z

Build Succeeded 👏

Build Id: 8bd2093c-a30c-467f-bf4c-cd7aaf65ec9a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.8.0-51697e1
image: gcr.io/agones-images/agones-sdk:1.8.0-51697e1
image: gcr.io/agones-images/agones-ping:1.8.0-51697e1
Linux C++ SDK (build): agonessdk-1.8.0-51697e1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.8.0-51697e1.zip

A preview of the website (the last 30 builds are retained):

https://51697e1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1716/head:pr_1716 && git checkout pr_1716
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.8.0-51697e1

markmandel

LGTM

google-oss-robot · 2020-07-28T17:12:40Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…v1.1.1 (googleforgames#1716) * Switch from master branch to more specific tag Fix a hidden error, caused by not working htmltest. * Fix hash does not exist error Links with # watch-gameserver becomes # watchgameserver. After Hugo update.

google-oss-robot requested review from devjgm, EricFortin and pooneh-m July 24, 2020 12:06

google-oss-robot added the size/XS label Jul 24, 2020

aLekSer self-assigned this Jul 24, 2020

aLekSer added the area/site The website itself - including redirects, styling, search, etc label Jul 24, 2020

googlebot added the cla: yes label Jul 24, 2020

aLekSer changed the title ~~Switch from master branch to more specific tag~~ CI: website OpenSSL Switch from master branch to more specific tag v1.1.1 Jul 24, 2020

Switch from master branch to more specific tag

7c35af3

Fix a hidden error, caused by not working htmltest.

aLekSer force-pushed the fix/openssl-links branch from aba1b8d to 7c35af3 Compare July 24, 2020 14:45

Fix hash does not exist error

3874bab

Links with # watch-gameserver becomes # watchgameserver. After Hugo update.

google-oss-robot added size/M and removed size/XS labels Jul 24, 2020

aLekSer changed the title ~~CI: website OpenSSL Switch from master branch to more specific tag v1.1.1~~ Website fix - OpenSSL Switch from master branch to more specific tag v1.1.1 Jul 27, 2020

Merge branch 'master' into fix/openssl-links

43d75a0

aLekSer mentioned this pull request Jul 28, 2020

CI: website htmltest fix returning error from the loop #1715

Merged

Merge branch 'master' into fix/openssl-links

51697e1

aLekSer requested a review from markmandel July 28, 2020 16:12

aLekSer removed request for EricFortin and devjgm July 28, 2020 16:34

markmandel approved these changes Jul 28, 2020

View reviewed changes

google-oss-robot assigned markmandel Jul 28, 2020

google-oss-robot added the lgtm label Jul 28, 2020

google-oss-robot added the approved label Jul 28, 2020

markmandel merged commit 5cafbfe into googleforgames:master Jul 28, 2020

markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Jul 28, 2020

aLekSer deleted the fix/openssl-links branch July 28, 2020 17:15

markmandel added this to the 1.8.0 milestone Aug 11, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Website fix - OpenSSL Switch from master branch to more specific tag v1.1.1 #1716

Website fix - OpenSSL Switch from master branch to more specific tag v1.1.1 #1716

aLekSer commented Jul 24, 2020 •

edited

Loading

agones-bot commented Jul 24, 2020

aLekSer commented Jul 24, 2020 •

edited

Loading

agones-bot commented Jul 24, 2020

agones-bot commented Jul 24, 2020

agones-bot commented Jul 28, 2020

aLekSer commented Jul 28, 2020

agones-bot commented Jul 28, 2020

markmandel left a comment

google-oss-robot commented Jul 28, 2020

Website fix - OpenSSL Switch from master branch to more specific tag v1.1.1 #1716

Website fix - OpenSSL Switch from master branch to more specific tag v1.1.1 #1716

Conversation

aLekSer commented Jul 24, 2020 • edited Loading

agones-bot commented Jul 24, 2020

aLekSer commented Jul 24, 2020 • edited Loading

agones-bot commented Jul 24, 2020

agones-bot commented Jul 24, 2020

agones-bot commented Jul 28, 2020

aLekSer commented Jul 28, 2020

agones-bot commented Jul 28, 2020

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Jul 28, 2020

aLekSer commented Jul 24, 2020 •

edited

Loading

aLekSer commented Jul 24, 2020 •

edited

Loading