Added a new 'disableTLS' flag and changed 'disableMTLS' to only disab… #1777

devloop0 · 2020-08-31T22:40:46Z

…le client auth.

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:
Adds an option to just disable client auth (so traditional TLS). (disableMTLS -> plainTLS, disableTLS -> full plaintext).

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

…le client auth.

pooneh-m

Thanks for the fix.

cmd/allocator/main.go

agones-bot · 2020-08-31T23:03:59Z

Build Failed 😱

Build Id: 10d58775-c8f1-43ab-93b7-059009e85b1e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2020-08-31T23:05:52Z

That's a new one:

--- FAIL: TestGameServerAllocationDeletionOnUnAllocate (0.11s)
    gameserverallocation_test.go:395: 
        	Error Trace:	gameserverallocation_test.go:395
        	Error:      	Expected nil, but got: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:"", RemainingItemCount:(*int64)(nil)}, Status:"Failure", Message:"the server is currently unable to handle the request (post gameserverallocations.allocation.agones.dev)", Reason:"ServiceUnavailable", Details:(*v1.StatusDetails)(0xc00045c060), Code:503}}
        	Test:       	TestGameServerAllocationDeletionOnUnAllocate

I think you managed to catch a master upgrade?

agones-bot · 2020-08-31T23:37:05Z

Build Succeeded 👏

Build Id: 1bb507d5-ea19-4979-b2d3-8d8ad4769b76

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.9.0-ca52b0c
image: gcr.io/agones-images/agones-sdk:1.9.0-ca52b0c
image: gcr.io/agones-images/agones-ping:1.9.0-ca52b0c
Linux C++ SDK (build): agonessdk-1.9.0-ca52b0c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.9.0-ca52b0c.zip

A preview of the website (the last 30 builds are retained):

https://ca52b0c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1777/head:pr_1777 && git checkout pr_1777
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-ca52b0c

devloop0 · 2020-08-31T23:44:30Z

I think you managed to catch a master upgrade?

Just my luck :D

The issue was probably intermittent since my next run passed.

agones-bot · 2020-09-01T00:13:35Z

Build Succeeded 👏

Build Id: 5cad4139-072c-4571-81e5-d0b1ad05d038

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.9.0-659a001
image: gcr.io/agones-images/agones-sdk:1.9.0-659a001
image: gcr.io/agones-images/agones-ping:1.9.0-659a001
Linux C++ SDK (build): agonessdk-1.9.0-659a001-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.9.0-659a001.zip

A preview of the website (the last 30 builds are retained):

https://659a001-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1777/head:pr_1777 && git checkout pr_1777
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-659a001

cmd/allocator/main.go

…to fix-tls-flags

agones-bot · 2020-09-01T23:38:22Z

Build Succeeded 👏

Build Id: cab9d43a-a1e5-4245-9b11-f48cdd4ba825

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.9.0-57a6d70
image: gcr.io/agones-images/agones-sdk:1.9.0-57a6d70
image: gcr.io/agones-images/agones-ping:1.9.0-57a6d70
Linux C++ SDK (build): agonessdk-1.9.0-57a6d70-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.9.0-57a6d70.zip

A preview of the website (the last 30 builds are retained):

https://57a6d70-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1777/head:pr_1777 && git checkout pr_1777
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-57a6d70

devloop0 · 2020-09-02T21:02:52Z

Added a comment explaining why the keepalive parameters are useful.
Also, tested this by:

Installing the agones allocator with a commit from this PR (image tag 1.9.0-57a6d70)
Putting it in front of a GKE ingress load balancer
Since GKE ingress requires TLS for HTTP2, the Agones allocator was installed with disableTLS=false, disableMTLS=true.
Confirmed that the ingress recognized the backend pods and was able to allocate gameservers by connecting to the ingress LB endpoint.

agones-bot · 2020-09-02T21:05:37Z

Build Succeeded 👏

Build Id: 089ed78b-245c-4c1c-964d-8637256d94d0

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.9.0-c59b193
image: gcr.io/agones-images/agones-sdk:1.9.0-c59b193
image: gcr.io/agones-images/agones-ping:1.9.0-c59b193
Linux C++ SDK (build): agonessdk-1.9.0-c59b193-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.9.0-c59b193.zip

A preview of the website (the last 30 builds are retained):

https://c59b193-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1777/head:pr_1777 && git checkout pr_1777
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-c59b193

google-oss-robot · 2020-09-02T22:25:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devloop0, pooneh-m

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pooneh-m]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pooneh-m · 2020-09-02T22:27:06Z

Thanks for the change.

googleforgames#1777) * Added a new 'disableTLS' flag and changed 'disableMTLS' to only disable client auth. * Conditionally disabled cert dir watching/reading on disableMTLS. * Added some keepalive parameters for health checks. * Changed logic to only have mTLS in the case of TLS. * Added a comment for why the keepalive options are necessary. Co-authored-by: Nikhil Athreya <nathreya@google.com>

Added a new 'disableTLS' flag and changed 'disableMTLS' to only disab…

ceb6161

…le client auth.

googlebot added the cla: yes label Aug 31, 2020

google-oss-robot requested review from EricFortin and pooneh-m August 31, 2020 22:40

google-oss-robot added the size/M label Aug 31, 2020

pooneh-m reviewed Aug 31, 2020

View reviewed changes

cmd/allocator/main.go Show resolved Hide resolved

Conditionally disabled cert dir watching/reading on disableMTLS.

ca52b0c

nathreya-google and others added 2 commits August 31, 2020 23:51

Added some keepalive parameters for health checks.

c0b2bf9

Merge branch 'master' into fix-tls-flags

659a001

pooneh-m reviewed Sep 1, 2020

View reviewed changes

cmd/allocator/main.go Show resolved Hide resolved

cmd/allocator/main.go Show resolved Hide resolved

nathreya-google added 2 commits September 1, 2020 23:16

Changed logic to only have mTLS in the case of TLS.

4be4715

Merge branch 'fix-tls-flags' of https://github.com/devloop0/agones in…

57a6d70

…to fix-tls-flags

google-oss-robot added size/L and removed size/M labels Sep 1, 2020

nathreya-google and others added 2 commits September 2, 2020 20:45

Added a comment for why the keepalive options are necessary.

628772f

Merge branch 'master' into fix-tls-flags

c59b193

pooneh-m approved these changes Sep 2, 2020

View reviewed changes

google-oss-robot assigned pooneh-m Sep 2, 2020

google-oss-robot added the lgtm label Sep 2, 2020

google-oss-robot added the approved label Sep 2, 2020

pooneh-m merged commit a1ce52c into googleforgames:master Sep 2, 2020

roberthbailey mentioned this pull request Sep 15, 2020

Only refresh certificates if the fsnotify event is relevant #1816

Closed

markmandel added this to the 1.9.0 milestone Sep 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added a new 'disableTLS' flag and changed 'disableMTLS' to only disab… #1777

Added a new 'disableTLS' flag and changed 'disableMTLS' to only disab… #1777

devloop0 commented Aug 31, 2020

pooneh-m left a comment

agones-bot commented Aug 31, 2020

markmandel commented Aug 31, 2020

agones-bot commented Aug 31, 2020

devloop0 commented Aug 31, 2020 •

edited

Loading

agones-bot commented Sep 1, 2020

agones-bot commented Sep 1, 2020

devloop0 commented Sep 2, 2020

agones-bot commented Sep 2, 2020

google-oss-robot commented Sep 2, 2020

pooneh-m commented Sep 2, 2020

Added a new 'disableTLS' flag and changed 'disableMTLS' to only disab… #1777

Added a new 'disableTLS' flag and changed 'disableMTLS' to only disab… #1777

Conversation

devloop0 commented Aug 31, 2020

pooneh-m left a comment

Choose a reason for hiding this comment

agones-bot commented Aug 31, 2020

markmandel commented Aug 31, 2020

agones-bot commented Aug 31, 2020

devloop0 commented Aug 31, 2020 • edited Loading

agones-bot commented Sep 1, 2020

agones-bot commented Sep 1, 2020

devloop0 commented Sep 2, 2020

agones-bot commented Sep 2, 2020

google-oss-robot commented Sep 2, 2020

pooneh-m commented Sep 2, 2020

devloop0 commented Aug 31, 2020 •

edited

Loading