Flaky: TestControllerGameServersNodeState #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This involves two things: (1) Adding a newFakeControllerWithMock to the metric test utilities to allow for pre-population -- which with the client-go updates make it far easier to write deterministic tests. (2) Updated TestControllerGameServersNodeState with the new mock construction. This included removing the c.run() command, which can run c.collect() at any point in time, and any number of times before the tests being checked, and replaced this a c.collect() so we can control exactly when metric collection occurs during the tests.
markmandel
added
kind/bug
|
Build Succeeded 👏 Build Id: ce505c13-372f-462e-966f-cf6c40955e05 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
aLekSer
approved these changes
Sep 11, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
This involves two things: (1) Adding a newFakeControllerWithMock to the metric test utilities to allow for pre-population -- which with the client-go updates make it far easier to write deterministic tests. (2) Updated TestControllerGameServersNodeState with the new mock construction. This included removing the c.run() command, which can run c.collect() at any point in time, and any number of times before the tests being checked, and replaced this a c.collect() so we can control exactly when metric collection occurs during the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
This involves two things:
(1) Adding a newFakeControllerWithMock to the metric test utilities to allow for pre-population -- which with the client-go updates make it far easier to write deterministic tests.
(2) Updated TestControllerGameServersNodeState with the new mock construction.
This included removing the c.run() command, which can run c.collect() at any point in time, and any number of times before the tests being checked, and replaced this a c.collect() so we can control exactly when metric collection occurs during the tests.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
Ran this a few hundred times, no failures.