Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kubectl to 1.16.15 #1806

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Updated both the build and the e2e image to Kubectl 1.16.15 (same as client-go etc)

Which issue(s) this PR fixes:

Work on #1649

Special notes for your reviewer:

N/A

Both the build and the e2e image.

Work on googleforgames#1649
@markmandel markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/breaking Breaking change labels Sep 11, 2020
@aLekSer
Copy link
Collaborator

aLekSer commented Sep 11, 2020

I wonder if a new version of Kubernetes code-generator would produce something different? I mean this line of Dockerfile was also impacted:

RUN mkdir -p /go/src/k8s.io && cd /go/src/k8s.io && \
    git clone -b kubernetes-${KUBERNETES_VER} --depth=3 https://github.com/kubernetes/code-generator.git

@markmandel
Copy link
Collaborator Author

I wonder if a new version of Kubernetes code-generator would produce something new? I mean this line of Dockerfile was also impacted:

RUN mkdir -p /go/src/k8s.io && cd /go/src/k8s.io && \
    git clone -b kubernetes-${KUBERNETES_VER} --depth=3 https://github.com/kubernetes/code-generator.git

Ooh, that's a good question. Lemme hop on that too.

@markmandel
Copy link
Collaborator Author

So I ran it - one small change in clientset.go -- I'll submit a PR once this is done (unless you want it in here?)

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0fb9cd9a-7996-44dd-b02c-b5087abf4e89

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think changes to generated crd-client can go into a separate PR. Just so all devs would have no surprising diff after running make gen-crd-client.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aLekSer
Copy link
Collaborator

aLekSer commented Sep 11, 2020

Looking at SDK conformance tests these days. This fail is the same as before - attempting to connect when SDK server is stopped.

make[2]: *** [run-sdk-conformance-no-build] Error 1
includes/sdk.mk:145: recipe for target 'run-sdk-conformance-no-build' failed
includes/sdk.mk:152: recipe for target 'run-sdk-conformance-test' failed
make[1]: *** [run-sdk-conformance-test] Error 2
includes/sdk.mk:159: recipe for target 'run-sdk-conformance-test-node' failed
make: *** [run-sdk-conformance-test-node] Error 2
make: *** Waiting for unfinished jobs....
# run with feature flags enabled
/usr/bin/make run-sdk-conformance-no-build SDK_FOLDER=go GRPC_PORT=9001 HTTP_PORT=9101 FEATURE_GATES=PlayerTracking=true TESTS=ready,allocate,setlabel,setannotation,gameserver,health,shutdown,watch,reserve,getplayercapacity,setplayercapacity,playerconnect,playerdisconnect,getplayercount,isplayerconnected,getconnectedplayers
+ /root/sdktest.sh
+ cd /go/src/agones.dev/agones/test/sdk/nodejs
+ npm run testSDK

> @ testSDK /go/src/agones.dev/agones/test/sdk/nodejs
> node ./testSDKClient.js

attempting to connect

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 93da8af6-8ba4-47d3-8953-55004e5e2a27

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1806/head:pr_1806 && git checkout pr_1806
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-1a10473

@aLekSer aLekSer merged commit fe14aea into googleforgames:master Sep 11, 2020
@markmandel markmandel deleted the upgrade/kubectl-1.16.x branch September 11, 2020 22:53
@markmandel markmandel added this to the 1.9.0 milestone Sep 11, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. cla: yes kind/breaking Breaking change lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants