Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix rest GetPlayerCount description #1811

Merged
merged 3 commits into from
Sep 15, 2020

Conversation

Reousa
Copy link
Contributor

@Reousa Reousa commented Sep 13, 2020

What type of PR is this?

/kind documentation

What this PR does / Why we need it:

Fixes the REST docs

Which issue(s) this PR fixes:
Closes #1810

Special notes for your reviewer:

I assumed that this behavior is also true for this entry:

This is always accurate from what has been set through this SDK, even if the value has yet to be updated on the GameServer status resource.

@Reousa Reousa changed the title Fix rest docs Docs: Fix rest GetPlayerCount description Sep 13, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 75c431eb-8531-4792-afbe-1fd1b25c738b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator

aLekSer commented Sep 13, 2020

It could be the case that we need to clean up E2E test cluster which could have dangling Fleets, as I saw it from my recent PRs updates and CI results.

Copy link
Collaborator

@aLekSer aLekSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing this missing section.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 228b955a-53e7-4486-b8b5-8103f0950a4a

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@aLekSer
Copy link
Collaborator

aLekSer commented Sep 14, 2020

I expect that CI would be fixed after #1808 .

@Reousa
Copy link
Contributor Author

Reousa commented Sep 14, 2020

Do tag me if a rebase is needed 👍

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 543555a3-6e75-48cc-8925-07aae8a35129

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel, Reousa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 31e1e9c5-2008-4b22-80ba-4f1d303125f1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1811/head:pr_1811 && git checkout pr_1811
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.9.0-9ae74ed

@markmandel markmandel added kind/bug These are bugs. kind/documentation Documentation for Agones labels Sep 15, 2020
@markmandel markmandel added this to the 1.9.0 milestone Sep 15, 2020
@markmandel markmandel merged commit f31221c into googleforgames:master Sep 15, 2020
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Alpha: GetPlayerCount description in the REST docs
6 participants