-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Fix rest GetPlayerCount
description
#1811
Conversation
Build Failed 😱 Build Id: 75c431eb-8531-4792-afbe-1fd1b25c738b To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
It could be the case that we need to clean up E2E test cluster which could have dangling Fleets, as I saw it from my recent PRs updates and CI results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for noticing this missing section.
Build Failed 😱 Build Id: 228b955a-53e7-4486-b8b5-8103f0950a4a To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
I expect that CI would be fixed after #1808 . |
Do tag me if a rebase is needed 👍 |
Build Failed 😱 Build Id: 543555a3-6e75-48cc-8925-07aae8a35129 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel, Reousa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: 31e1e9c5-2008-4b22-80ba-4f1d303125f1 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Co-authored-by: Alexander Apalikov <alexander.apalikov@globant.com>
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
Fixes the REST docs
Which issue(s) this PR fixes:
Closes #1810
Special notes for your reviewer:
I assumed that this behavior is also true for this entry: