-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin npm autoprefixer package for site generation #1818
Conversation
The 10.0.0 release of autoprefixer broke site generation, so pinning the version to a 9.x.x release. This will unclog CI as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point this is going to come back and bite us if we forget to ever check to see if they fix things (or figure out how to upgrade to post 10.0.0) but this seems like a reasonable short term fix. Can you open a tracking bug to get back onto a non-pinned version in the future?
Should we create a ticket to update this dependency -- or should the ticket be to upgrade hugo+docsy, and therefore the whole suite of dependencies? (I expect at some point Hugo/Docsy will work out how to work with the new version) |
Either way is fine, just as long as we don't stay pinned forever and forget about it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aLekSer, markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Build Succeeded 👏 Build Id: ec2e55da-7959-4ff2-b67c-77cb5a6bf28e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
The 10.0.0 release of autoprefixer broke site generation, so pinning the version to a 9.x.x release. This will unclog CI as well.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
The 10.0.0 release of autoprefixer broke site generation, so pinning the version to a 9.x.x release.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
This will unclog CI as well.