-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gRPC dial timeout to game server allocation policy (#1700) #1830
Conversation
When using the multicluster allocator dialing remote clusters can cause allocation requests to block for 2 minutes + In order to control dial timeout of allocation requests Timeout, BackoffCap properties were added to game server allocation policy
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yeukovichd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Build Failed 😱 Build Id: 64a2fbf0-12bc-4fe7-9726-34c3f462f376 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 788f52d9-7afc-4ee2-b1bd-863993efcdca To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 34ce30f0-722f-496e-b11e-bb11323d882b To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
@yeukovichd is this change is still relevant or we should close the PR? Here is my thought on the per cluster timeout policy: #1700 (comment) |
This PR hasn't been updated for 21 days, can we close it now? |
Closing this PR due to inactivity and it seems that we are on the agreement that the change is not needed anymore. |
When using the multicluster allocator dialing remote clusters can cause
allocation requests to block for 2 minutes +
In order to control dial timeout of allocation requests Timeout, BackoffCap properties
were added to game server allocation policy
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Which issue(s) this PR fixes:
Closes #1700
Special notes for your reviewer: