Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gRPC dial timeout to game server allocation policy (#1700) #1830

Closed
wants to merge 3 commits into from

Conversation

yeukovichd
Copy link

@yeukovichd yeukovichd commented Sep 24, 2020

When using the multicluster allocator dialing remote clusters can cause
allocation requests to block for 2 minutes +

In order to control dial timeout of allocation requests Timeout, BackoffCap properties
were added to game server allocation policy

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #1700

Special notes for your reviewer:

When using the multicluster allocator dialing remote clusters can cause
allocation requests to block for 2 minutes +

In order to control dial timeout of allocation requests Timeout, BackoffCap properties
were added to game server allocation policy
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yeukovichd
To complete the pull request process, please assign markmandel
You can assign the PR to them by writing /assign @markmandel in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 64a2fbf0-12bc-4fe7-9726-34c3f462f376

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 24, 2020
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 788f52d9-7afc-4ee2-b1bd-863993efcdca

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 34ce30f0-722f-496e-b11e-bb11323d882b

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 29, 2020
@pooneh-m
Copy link
Contributor

@yeukovichd is this change is still relevant or we should close the PR? Here is my thought on the per cluster timeout policy: #1700 (comment)

@markmandel markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Nov 3, 2020
@markmandel markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Nov 11, 2020
@markmandel
Copy link
Collaborator

This PR hasn't been updated for 21 days, can we close it now?

@pooneh-m
Copy link
Contributor

pooneh-m commented Dec 4, 2020

Closing this PR due to inactivity and it seems that we are on the agreement that the change is not needed anymore.

@pooneh-m pooneh-m closed this Dec 4, 2020
@markmandel markmandel deleted the fix/1700-multicluster-grpc-dial-timeout branch December 11, 2020 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multicluster: Add gRPC dial timeout
6 participants