Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand feature freeze details during RC. #1847

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation
/kind feature
/kind hotfix

/kind meta

What this PR does / Why we need it:

There have been a few discussions on what PRs get merged during release candidate, which I think is down to the release documentation not being as clear as it could be.

This should make the guidelines for what should go through and what should be held back during release candidate clearer.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

There have been a few discussions on what PRs get merged during
release candidate, which I think is down to the release documentation
not being as clear as it could be.

This should make the guidelines for what should go through and what
should be held back during release candidate clearer.
@markmandel markmandel added the area/meta Organisational matters. e.g. Governance, release cycles, etc. label Oct 15, 2020
@google-cla google-cla bot added the cla: yes label Oct 15, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f3219162-4d70-4f77-b5c4-0fa6feacde53

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1847/head:pr_1847 && git checkout pr_1847
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-df8d44b

@markmandel markmandel merged commit 2fa2be4 into googleforgames:master Oct 15, 2020
@markmandel markmandel added this to the 1.10.0 milestone Oct 15, 2020
@markmandel markmandel deleted the meta/freeze-items branch October 16, 2020 20:07
ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020
There have been a few discussions on what PRs get merged during
release candidate, which I think is down to the release documentation
not being as clear as it could be.

This should make the guidelines for what should go through and what
should be held back during release candidate clearer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/meta Organisational matters. e.g. Governance, release cycles, etc. cla: yes lgtm size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants