Add more more retries to htmltest #1861

markmandel · 2020-10-22T17:39:43Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Either we have way more links or Github is being more aggressive with it's 429 response to HTTP requests to check links.

So adding lots more retries to this test, to account for this.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

We could potentially apply something like:
https://medium.com/@davidstanke/make-a-cloud-build-step-that-always-succeeds-9d23290a2f4e
long term if we want to always cache the htmltest link results even on
failure of this step.

Either we have way more links or Github is being more aggressive with it's 429 response to HTTP requests to check links. So adding lots more retries to this test, to account for this. We could potentially apply something like: https://medium.com/@davidstanke/make-a-cloud-build-step-that-always-succeeds-9d23290a2f4e long term if we want to always cache the htmltest link results even on failure of this step.

agones-bot · 2020-10-22T18:16:12Z

Build Succeeded 👏

Build Id: d1151f3e-64b2-4ce1-a6c1-eb531bd7292d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.10.0-6cd45d5
image: gcr.io/agones-images/agones-sdk:1.10.0-6cd45d5
image: gcr.io/agones-images/agones-ping:1.10.0-6cd45d5
Linux C++ SDK (build): agonessdk-1.10.0-6cd45d5-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.10.0-6cd45d5.zip

A preview of the website (the last 30 builds are retained):

https://6cd45d5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1861/head:pr_1861 && git checkout pr_1861
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-6cd45d5

roberthbailey · 2020-10-22T20:35:21Z

I think the 429s might have been a red herring. I found a bad link after carefully scanning the list and once I fixed that the tests passed.

markmandel · 2020-10-22T20:40:39Z

This test did take 8 retries until it passed again.. so I'm not entirely sure it was.

....
Html Test: Attempt 7
htmltest started at 06:03:36 on /tmp/website
========================================================================
site/blog/2019/02/13/0.8.0-release-candidate/index.html
  Non-OK status: 429 --- site/blog/2019/02/13/0.8.0-release-candidate/index.html --> https://github.com/Yingxin-Jiang
  Non-OK status: 429 --- site/blog/2019/02/13/0.8.0-release-candidate/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/566
  Non-OK status: 429 --- site/blog/2019/02/13/0.8.0-release-candidate/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/564
  Non-OK status: 429 --- site/blog/2019/02/13/0.8.0-release-candidate/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/559
  Non-OK status: 429 --- site/blog/2019/02/13/0.8.0-release-candidate/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/558
  Non-OK status: 429 --- site/blog/2019/02/13/0.8.0-release-candidate/index.html --> https://github.com/jeremyje
  Non-OK status: 429 --- site/blog/2019/02/13/0.8.0-release-candidate/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/551
  Non-OK status: 429 --- site/blog/2019/02/13/0.8.0-release-candidate/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/539
site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html
  Non-OK status: 429 --- site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html --> https://github.com/Yingxin-Jiang
  Non-OK status: 429 --- site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/566
  Non-OK status: 429 --- site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/564
  Non-OK status: 429 --- site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/559
  Non-OK status: 429 --- site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/558
  Non-OK status: 429 --- site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html --> https://github.com/jeremyje
  Non-OK status: 429 --- site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/551
  Non-OK status: 429 --- site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html --> https://github.com/GoogleCloudPlatform/agones/pull/539
  Non-OK status: 429 --- site/blog/2019/02/20/0.8.0-gameserverallocations-performance-improvements-monitoring-improvements-and-more/index.html --> https://github.com/GoogleCloudPlatform/agones/blob/release-0.8.0/CHANGELOG.md
========================================================================
✘✘✘ failed in 34.258850012s
17 errors in 118 documents
Html Test: Attempt 8
htmltest started at 06:05:11 on /tmp/website
========================================================================
✔✔✔ passed in 10.718465097s
tested 118 documents
make[1]: Leaving directory '/workspace/build'

Once it completed, the link cache was populated in GCS, so your PR's tests also passed, since it didn't have to hit Github.

So maybe both?

roberthbailey · 2020-10-22T21:00:47Z

The fact that this PR got 7 failures doing link checking is definitely a different issue than I fixed.

google-oss-robot · 2020-10-22T21:01:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-10-22T21:01:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2020-10-22T21:21:44Z

Build Succeeded 👏

Build Id: a598f626-bef2-4ee3-895a-c7412b776ffb

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.10.0-f8ddf1e
image: gcr.io/agones-images/agones-sdk:1.10.0-f8ddf1e
image: gcr.io/agones-images/agones-ping:1.10.0-f8ddf1e
Linux C++ SDK (build): agonessdk-1.10.0-f8ddf1e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.10.0-f8ddf1e.zip

A preview of the website (the last 30 builds are retained):

https://f8ddf1e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/1861/head:pr_1861 && git checkout pr_1861
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.10.0-f8ddf1e

Either we have way more links or Github is being more aggressive with it's 429 response to HTTP requests to check links. So adding lots more retries to this test, to account for this. We could potentially apply something like: https://medium.com/@davidstanke/make-a-cloud-build-step-that-always-succeeds-9d23290a2f4e long term if we want to always cache the htmltest link results even on failure of this step. Co-authored-by: Robert Bailey <robertbailey@google.com>

markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Oct 22, 2020

markmandel requested review from roberthbailey and pooneh-m October 22, 2020 17:39

google-oss-robot requested a review from aLekSer October 22, 2020 17:39

google-oss-robot added approved size/XS labels Oct 22, 2020

google-cla bot added the cla: yes label Oct 22, 2020

markmandel mentioned this pull request Oct 22, 2020

Remove the documentation for helm v2 #1859

Merged

Merge branch 'master' into tests/more-html-test-retry

f8ddf1e

roberthbailey approved these changes Oct 22, 2020

View reviewed changes

google-oss-robot assigned roberthbailey Oct 22, 2020

google-oss-robot added the lgtm label Oct 22, 2020

markmandel merged commit e3ca99c into googleforgames:master Oct 22, 2020

markmandel added this to the 1.10.0 milestone Oct 22, 2020

markmandel deleted the tests/more-html-test-retry branch October 27, 2020 19:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add more more retries to htmltest #1861

Add more more retries to htmltest #1861

markmandel commented Oct 22, 2020

agones-bot commented Oct 22, 2020

roberthbailey commented Oct 22, 2020

markmandel commented Oct 22, 2020

roberthbailey commented Oct 22, 2020

google-oss-robot commented Oct 22, 2020

google-oss-robot commented Oct 22, 2020

agones-bot commented Oct 22, 2020

Add more more retries to htmltest #1861

Add more more retries to htmltest #1861

Conversation

markmandel commented Oct 22, 2020

agones-bot commented Oct 22, 2020

roberthbailey commented Oct 22, 2020

markmandel commented Oct 22, 2020

roberthbailey commented Oct 22, 2020

google-oss-robot commented Oct 22, 2020

google-oss-robot commented Oct 22, 2020

agones-bot commented Oct 22, 2020