Updated Go to 1.14.12

[markmandel]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Security fixes really.

Which issue(s) this PR fixes:

Special notes for your reviewer:
Specifically didn't upgrade to 1.15.x due to issues with SSL certificates on fleet autoscaler webhooks. See #1897.

I've also not incremented example image versions, since I figured this wasn't a breaking change, and the new version could be picked up as other changes happen to those images.

[agones-bot]

Build Succeeded 👏

Build Id: bb28b31b-aef3-4cdd-9658-57258d05222d

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.11.0-85b26c1
• image: gcr.io/agones-images/agones-sdk:1.11.0-85b26c1
• image: gcr.io/agones-images/agones-ping:1.11.0-85b26c1
• Linux C++ SDK (build): agonessdk-1.11.0-85b26c1-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.11.0-85b26c1.zip

A preview of the website (the last 30 builds are retained):

• https://85b26c1-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1900/head:pr_1900 && git checkout pr_1900
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-85b26c1

[roberthbailey]

I've also not incremented example image versions, since I figured this wasn't a breaking change, and the new version could be picked up as other changes happen to those images.

If this is to pick up security fixes, shouldn't we rebuild and push new images (with the next release)? Otherwise, what is the point of updating the go version. Something like the supertuxcart example image, which isn't under active development isn't going to get a new version on its own any time soon. And things like the simple-game-server aren't likely to be changed but are used in all of our examples and it would be good to have users running a secured version.

[roberthbailey]

Code changes look good, just want to resolve the question about container image versions.

[google-oss-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[markmandel]

If this is to pick up security fixes, shouldn't we rebuild and push new images (with the next release)? Otherwise, what is the point of updating the go version. Something like the supertuxcart example image, which isn't under active development isn't going to get a new version on its own any time soon. And things like the simple-game-server aren't likely to be changed but are used in all of our examples and it would be good to have users running a secured version.

If I'm honest, I didn't do it, because it's a lot of busywork, and the security of an example images doesn't seem to me to be a huge priority? So figured, it would be taken care of on a best effort basis, rather than being a blocker for a release.

SuperTuxKart should actually get updated - a new version came out a little while ago, I believe with the AI connection fixes. I don't think Xonotic has though.

[roberthbailey]

That's fair. How about filing a help-wanted issue to update the example images? Collecting the list of things that need to be rebuilt would be pretty straightforward.

[markmandel]

Sounds like a plan - do we restart #1261 or start a new one? 😄

[roberthbailey]

That issue is sooooo close.... But since it's already open, I think we should just re-use it.

[markmandel]

How's this?
#1261 (comment)

[google-oss-robot]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Failed 😱

Build Id: 50374ba1-4327-4913-9933-1b884a165ba3

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: 5474356c-1cec-40e7-bceb-d60ea3f986f9

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Succeeded 👏

Build Id: 318f9675-9e33-4b89-aac7-3807e2b1e304

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.11.0-a6c7e59
• image: gcr.io/agones-images/agones-sdk:1.11.0-a6c7e59
• image: gcr.io/agones-images/agones-ping:1.11.0-a6c7e59
• Linux C++ SDK (build): agonessdk-1.11.0-a6c7e59-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.11.0-a6c7e59.zip

A preview of the website (the last 30 builds are retained):

• https://a6c7e59-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/1900/head:pr_1900 && git checkout pr_1900
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-a6c7e59

[roberthbailey]

How's this?
#1261 (comment)

Great. Thanks!