Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated CRD libraries to v1 #1922

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Updated CRD libraries to v1 #1922

merged 1 commit into from
Dec 9, 2020

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:
Last piece of moving everything from v1beta1 to v1 in the Go code library usage.

Which issue(s) this PR fixes:

Closes #1799

Special notes for your reviewer:

No change in end user experience.

@markmandel
Updated CRD libraries to v1
be26495 
Last piece of moving everything from v1beta1 to v1 in the Go code
library usage.

Closes googleforgames#1799
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Dec 9, 2020
@google-cla google-cla bot added the cla: yes label Dec 9, 2020
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 798bf976-9c0d-4ef0-b162-13ffefd04331

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/1922/head:pr_1922 && git checkout pr_1922
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.11.0-be26495

@roberthbailey roberthbailey merged commit 7819f53 into googleforgames:master Dec 9, 2020
@markmandel markmandel deleted the cleanup/crd-lib-v1 branch December 9, 2020 21:54
@markmandel markmandel added this to the 1.11.0 milestone Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@pooneh-m pooneh-m Awaiting requested review from pooneh-m

@cyriltovena cyriltovena Awaiting requested review from cyriltovena

Assignees

@roberthbailey roberthbailey

Labels
approved cla: yes kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/M
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Update apiextensions.k8s.io/v1beta1 to v1 for all CRDs
4 participants
@markmandel @google-oss-robot @agones-bot @roberthbailey