Update AKS terraform install template #2165

WeetA34 · 2021-07-01T15:47:02Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Add missing required features block in provider azurerm definition:
During previous PR cleanup, the azurerm block has been removed but it's mandatory to define features
Replace interpolation-only expressions in outputs
Define static network_security_group_name in network_security_group_rule
After finding in aks-engine sources how the dynamic part of node pool network security group names isdefined (based on hash of cluster dns_prefix), we can use a static group name to avoid random issue with azurerm_resources datasource which randomly returns an empty array
Ignore resource_group_name changes (random case Azure issue) in network security group rule:
Azure randomly returns lowercased resource_group_name in network_security_group_rule resource. So, terraform plan/apply may want to re-create the network security group rule. To avoid that, an ignore_changes lifecycle block has been added.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

* Set azurerm provider version to = 2.63.0 because it seems more stable to get existing security groups * Replace interpolation-only expressions in outputs

WeetA34 · 2021-07-01T15:49:08Z

@dzmitry-lahoda
It seems that provider 2.63.0 doesn't have issue when getting existing Network Security Groups.
regarding resource_group_name, as you reported in my previous PR comments, it's randomly lowercased. So, i added ignore_changes block

* Set azurerm provider version to = 2.63.0 because it seems more stable to get existing security groups * Replace interpolation-only expressions in outputs * Ignore resource_group_name changes (random case Azure issue) in network security group rule

…gones into update-aks-tf-template

agones-bot · 2021-07-01T16:11:46Z

Build Succeeded 👏

Build Id: e1d1f7d5-757d-484e-a364-614571cb3824

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-6377c2d
image: gcr.io/agones-images/agones-ping:1.16.0-6377c2d
Linux C++ SDK (build): agonessdk-1.16.0-6377c2d-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-6377c2d.zip

A preview of the website (the last 30 builds are retained):

https://6377c2d-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2165/head:pr_2165 && git checkout pr_2165
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-6377c2d

agones-bot · 2021-07-01T16:24:05Z

Build Succeeded 👏

Build Id: fba99ff9-4166-4db2-9a75-5178ebf4d0e1

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-9ec2367
image: gcr.io/agones-images/agones-ping:1.16.0-9ec2367
Linux C++ SDK (build): agonessdk-1.16.0-9ec2367-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-9ec2367.zip

A preview of the website (the last 30 builds are retained):

https://9ec2367-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2165/head:pr_2165 && git checkout pr_2165
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-9ec2367

WeetA34 · 2021-07-01T16:30:51Z

No issue with terraform 0.12.31 and Azurerm 2.63.0 (set in PR) from scratch (tested twice)

$ terraform apply

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  + create
 <= read (data resources)

Terraform will perform the following actions:
...
Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes

module.aks_cluster.azurerm_resource_group.agones_rg: Creating...
module.aks_cluster.azurerm_resource_group.agones_rg: Creation complete after 3s [id=/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/agonesRG]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Creating...
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [10s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [20s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [30s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [40s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [50s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [1m0s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [1m10s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [1m20s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [1m30s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [1m40s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [1m50s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [2m0s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [2m10s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [2m20s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [2m30s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [2m40s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [2m50s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [3m0s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [3m10s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [3m20s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [3m30s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [3m40s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [3m50s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [4m0s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [4m10s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [4m20s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Still creating... [4m30s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster.agones: Creation complete after 4m36s [id=/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourcegroups/agonesRG/providers/Microsoft.ContainerService/managedClusters/test-cluster]
module.aks_cluster.data.azurerm_resources.network_security_groups: Refreshing state...
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Creating...
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Creating...
module.aks_cluster.azurerm_network_security_rule.gameserver: Creating...
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [10s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [10s elapsed]
module.aks_cluster.azurerm_network_security_rule.gameserver: Still creating... [10s elapsed]
module.aks_cluster.azurerm_network_security_rule.gameserver: Creation complete after 14s [id=/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/MC_agonesRG_test-cluster_eastus/providers/Microsoft.Network/networkSecurityGroups/aks-agentpool-55978144-nsg/securityRules/gameserver]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [20s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [20s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [30s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [30s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [40s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [40s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [50s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [50s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [1m0s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [1m0s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [1m10s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [1m10s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [1m20s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [1m20s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [1m30s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [1m30s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [1m40s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [1m40s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [1m50s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [1m50s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [2m0s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [2m0s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [2m10s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [2m10s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [2m20s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [2m20s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [2m30s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [2m30s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [2m40s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [2m40s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [2m50s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [2m50s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Still creating... [3m0s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Still creating... [3m0s elapsed]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.metrics: Creation complete after 3m9s [id=/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourcegroups/agonesRG/providers/Microsoft.ContainerService/managedClusters/test-cluster/agentPools/metrics]
module.aks_cluster.azurerm_kubernetes_cluster_node_pool.system: Creation complete after 3m9s [id=/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourcegroups/agonesRG/providers/Microsoft.ContainerService/managedClusters/test-cluster/agentPools/system]
module.helm_agones.helm_release.agones: Creating...
module.helm_agones.helm_release.agones: Still creating... [10s elapsed]
module.helm_agones.helm_release.agones: Still creating... [20s elapsed]
module.helm_agones.helm_release.agones: Still creating... [30s elapsed]
module.helm_agones.helm_release.agones: Creation complete after 33s [id=agones]

Apply complete! Resources: 6 added, 0 changed, 0 destroyed.

markmandel · 2021-07-01T19:53:24Z

@dzmitry-lahoda let me know if this works for you and is good to merge 😄 looks like you two own the AKS experience now.

…update-aks-tf-template

agones-bot · 2021-07-01T20:38:45Z

Build Succeeded 👏

Build Id: 75a61125-6829-4371-ae47-a6df139b6102

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-d17a9f9
image: gcr.io/agones-images/agones-ping:1.16.0-d17a9f9
Linux C++ SDK (build): agonessdk-1.16.0-d17a9f9-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-d17a9f9.zip

A preview of the website (the last 30 builds are retained):

https://d17a9f9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2165/head:pr_2165 && git checkout pr_2165
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-d17a9f9

…update-aks-tf-template

agones-bot · 2021-07-02T07:55:17Z

Build Succeeded 👏

Build Id: 1f6a13e2-f280-4c00-9cb6-6ab96280d3e2

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-145170b
image: gcr.io/agones-images/agones-ping:1.16.0-145170b
Linux C++ SDK (build): agonessdk-1.16.0-145170b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-145170b.zip

A preview of the website (the last 30 builds are retained):

https://145170b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2165/head:pr_2165 && git checkout pr_2165
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-145170b

WeetA34 · 2021-07-04T10:41:48Z

yep main branch doesn't lock to azurer provider 2.63.0
PR is locked to 2.63.0 because it seems to be less problematic.
Don't forget terraform init -upgrade (or delete .terraform) before deploying new cluster

dzmitry-lahoda · 2021-07-04T11:15:48Z

azurerm_kubernetes_cluster_node_pool.system: Still creating... [3m0s elapsed]
azurerm_kubernetes_cluster_node_pool.system: Creation complete after 3m9s [id=/subscriptions/..../resourcegroups/rglahoda/providers/Microsoft.ContainerService/managedClusters/dztestcluster/agentPools/system]
azurerm_kubernetes_cluster_node_pool.metrics: Creation complete after 3m9s [id=/subscriptions/..../resourcegroups/rglahoda/providers/Microsoft.ContainerService/managedClusters/dztestcluster/agentPools/metrics]
╷
│ Error: Invalid index
│
│   on aks.tf line 112, in resource "azurerm_network_security_rule" "gameserver":
│  112:   network_security_group_name = [for network_security_group in data.azurerm_resources.network_security_groups.resources : network_security_group.name if length(regexall("^aks-agentpool-\\d+-nsg$", network_security_group.name)) > 0][0]
│     ├────────────────
│     │ data.azurerm_resources.network_security_groups.resources is empty list of object
│
│ The given key does not identify an element in this collection value.
╵
....\agones\install\terraform\modules\aks [update-aks-tf-template ≡ +0 ~2 -0 | +0 ~1 -0 !]> git branch
  main
* update-aks-tf-template
.....\agones\install\terraform\modules\aks [update-aks-tf-template ≡ +0 ~2 -0 | +0 ~1 -0 !]>

same as in master on first attempt. there is official issue for MS to allow access to background network. so in this case may be https://registry.terraform.io/providers/hashicorp/time/latest/docs/resources/sleep help

running apply again.

dzmitry-lahoda · 2021-07-04T11:28:19Z

Apply complete! Resources: 1 added, 0 changed, 0 destroyed.

dzmitry-lahoda · 2021-07-04T11:28:50Z

Don't forget terraform init -upgrade (or delete .terraform) before deploying new cluster

did it

WeetA34 · 2021-07-04T11:56:12Z

weird, i deployed twice from scratch with terraform 0.12.31 and azurerm 2.63.0 without any issue

WeetA34 · 2021-07-04T11:58:33Z

i can add a sleep resource but as it's random, i'm not sure how many seconds/minutes to wait

dzmitry-lahoda · 2021-07-04T12:27:07Z

i can add a sleep resource but as it's random, i'm not sure how many seconds/minutes to wait

30 seconds in variables. i will experiment with increased values.

WeetA34 · 2021-07-04T12:28:44Z

I'm deploying a fresh new cluster without sleep with terraform 1.0.1 (instead of 0.12.31) and azurerm 2.63.0

WeetA34 · 2021-07-04T12:36:17Z

2 tests without any issue with terraform 0.12.31 and azurerm 2.63.0
1 test failed with terraform 1.0.1 and azurerm 2.63.0

$ terraform state show module.aks_cluster.data.azurerm_resources.network_security_groups
# module.aks_cluster.data.azurerm_resources.network_security_groups:
data "azurerm_resources" "network_security_groups" {
    id                  = "resource-28cc1555-9fcb-42d6-acd2-4d13b416087a"
    resource_group_name = "MC_agonesRG_test-cluster_eastus"
    resources           = []
    type                = "Microsoft.Network/networkSecurityGroups"
}

WeetA34 · 2021-07-04T12:40:01Z

after waiting multiple minutes, datasource is still empty

WeetA34 · 2021-07-04T12:54:51Z

ok after more than 5 minutes

WeetA34 · 2021-07-04T15:02:15Z

$ terraform version
Terraform v1.0.1
on linux_amd64
+ provider registry.terraform.io/hashicorp/azurerm v2.66.0
+ provider registry.terraform.io/hashicorp/helm v1.3.2

$ terraform apply
...
Apply complete! Resources: 6 added, 0 changed, 0 destroyed.

…update-aks-tf-template

…gones into update-aks-tf-template

agones-bot · 2021-07-04T16:10:55Z

Build Succeeded 👏

Build Id: f2971b59-233e-4a60-ad44-1b14ba41e910

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-a80c30a
image: gcr.io/agones-images/agones-ping:1.16.0-a80c30a
Linux C++ SDK (build): agonessdk-1.16.0-a80c30a-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-a80c30a.zip

A preview of the website (the last 30 builds are retained):

https://a80c30a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2165/head:pr_2165 && git checkout pr_2165
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-a80c30a

WeetA34 · 2021-07-04T16:17:45Z

Hello again @dzmitry-lahoda , i pushed a new version with static network security group name (the one which match cluster dns_prefix agones)

agones-bot · 2021-07-05T08:07:56Z

Build Succeeded 👏

Build Id: 8c62c3c9-682c-4be6-ad4e-6eae8f31ed25

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-f450580
image: gcr.io/agones-images/agones-ping:1.16.0-f450580
Linux C++ SDK (build): agonessdk-1.16.0-f450580-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-f450580.zip

A preview of the website (the last 30 builds are retained):

https://f450580-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2165/head:pr_2165 && git checkout pr_2165
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-f450580

WeetA34 · 2021-07-05T19:01:38Z

Hello @dzmitry-lahoda, can you confirm (when you have time) the last commit of this pr branch is ok? thank you

dzmitry-lahoda · 2021-07-06T12:24:15Z

thanks, i am ok with:) hope it will be stable, may be add comment into name resource telling not to rename it:) OR hash it in TF:)

WeetA34 · 2021-07-06T12:27:01Z

thank you
i already put a comment before dns_prefix
i've checked how to create hash in HCL directly in TF but i didn't find a solution (needs uint64, xor)

WeetA34 · 2021-07-06T14:45:28Z

Hello @markmandel
it seems you can merge :)
thank you

WeetA34 · 2021-07-06T16:32:22Z

regarding our issue with azurerm_resources datasource updated after a while, i found this which explains it:
Azure/AKS#1964 (comment)

there is a regional cache. That explains why i didn't have the issue the first time because i've deployed the cluster in an european location

WeetA34 · 2021-07-06T17:00:06Z

i confirm that datasource works fine when using the regional location as location for the AKS cluster.
in my case, management.azure.com resolves to the germanywestcentral endpoint

$ dig +noall +answer management.azure.com
management.azure.com.   0       IN      CNAME   management.privatelink.azure.com.
management.privatelink.azure.com. 0 IN  CNAME   arm-frontdoor-prod.trafficmanager.net.
arm-frontdoor-prod.trafficmanager.net. 0 IN CNAME germanywestcentral.management.azure.com.
germanywestcentral.management.azure.com. 0 IN CNAME rpfd-germanywestcentral.cloudapp.net.
rpfd-germanywestcentral.cloudapp.net. 0 IN A    51.116.156.32

no issue during cluster creation using azurerm_resources datasource. az cli also returns the security group just after terraform has finished. It took almost 20 minutes when i used eastus

$ terraform apply
...
Apply complete! Resources: 6 added, 0 changed, 0 destroyed.
 
$ az network nsg list
[
  {
    "defaultSecurityRules": [
...
    "name": "aks-agentpool-55978144-nsg",
    "networkInterfaces": null,
    "provisioningState": "Succeeded",
    "resourceGroup": "mc_agonesrg_test-cluster_germanywestcentral",
...
]

WeetA34 · 2021-07-06T17:01:22Z

so until to have a way to bypass the regional cache, the best option is not using datasource which this PR does

markmandel · 2021-07-08T22:40:07Z

👋🏻 just checking in, and scrolling past allll the comments 😄 this good to go, or we still playing with it?

WeetA34 · 2021-07-09T06:23:35Z

Good to go. I’ve have no solution for the regional cache so i can’t put back the azurerm_resources data source.

…update-aks-tf-template

agones-bot · 2021-07-09T08:20:54Z

Build Succeeded 👏

Build Id: 954aa7a5-b714-47be-a62f-8775be40d974

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-6d53ca7
image: gcr.io/agones-images/agones-ping:1.16.0-6d53ca7
Linux C++ SDK (build): agonessdk-1.16.0-6d53ca7-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-6d53ca7.zip

A preview of the website (the last 30 builds are retained):

https://6d53ca7-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2165/head:pr_2165 && git checkout pr_2165
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-6d53ca7

markmandel · 2021-07-09T16:56:21Z

@dzmitry-lahoda you happy too? In which case, we can land this before RC next week 👍🏻

google-oss-robot · 2021-07-13T17:43:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, WeetA34

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

agones-bot · 2021-07-13T18:08:37Z

Build Succeeded 👏

Build Id: 15b9e7fd-200f-4dd5-9112-bfa3e655ddc5

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.16.0-6b57ad2
image: gcr.io/agones-images/agones-ping:1.16.0-6b57ad2
Linux C++ SDK (build): agonessdk-1.16.0-6b57ad2-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.16.0-6b57ad2.zip

A preview of the website (the last 30 builds are retained):

https://6b57ad2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2165/head:pr_2165 && git checkout pr_2165
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-6b57ad2

* Add missing required features block in provider azurerm block

6377c2d

* Set azurerm provider version to = 2.63.0 because it seems more stable to get existing security groups * Replace interpolation-only expressions in outputs

google-oss-robot requested review from cyriltovena and dzlier-gcp July 1, 2021 15:47

google-cla bot added the cla: yes label Jul 1, 2021

google-oss-robot added the size/S label Jul 1, 2021

WeetA34 added 2 commits July 1, 2021 17:55

Merge branch 'update-aks-tf-template' of https://github.com/WeetA34/a…

9ec2367

…gones into update-aks-tf-template

google-oss-robot added size/M and removed size/S labels Jul 1, 2021

Merge branch 'main' of https://github.com/googleforgames/agones into …

d17a9f9

…update-aks-tf-template

Merge branch 'main' of https://github.com/googleforgames/agones into …

145170b

…update-aks-tf-template

WeetA34 mentioned this pull request Jul 2, 2021

Fix Network Security Group Gameserver rule not applied on AKS cluster #2124

Merged

WeetA34 added 2 commits July 4, 2021 17:42

Merge branch 'main' of https://github.com/googleforgames/agones into …

b005b94

…update-aks-tf-template

Merge branch 'update-aks-tf-template' of https://github.com/WeetA34/a…

a80c30a

…gones into update-aks-tf-template

Add comment regarding the fact we don't use azurerm_resources datasource

f450580

Merge branch 'main' of https://github.com/googleforgames/agones into …

6d53ca7

…update-aks-tf-template

Merge branch 'main' into update-aks-tf-template

6b57ad2

markmandel approved these changes Jul 13, 2021

View reviewed changes

google-oss-robot assigned markmandel Jul 13, 2021

google-oss-robot added the lgtm label Jul 13, 2021

google-oss-robot added the approved label Jul 13, 2021

markmandel merged commit efe0874 into googleforgames:main Jul 13, 2021

markmandel added this to the 1.16.0 milestone Jul 13, 2021

markmandel added area/operations Installation, updating, metrics etc kind/cleanup Refactoring code, fixing up documentation, etc labels Jul 13, 2021

Update AKS terraform install template #2165

Update AKS terraform install template #2165

Conversation

WeetA34 commented Jul 1, 2021 • edited Loading

WeetA34 commented Jul 1, 2021 • edited Loading

agones-bot commented Jul 1, 2021

agones-bot commented Jul 1, 2021

WeetA34 commented Jul 1, 2021

markmandel commented Jul 1, 2021

agones-bot commented Jul 1, 2021

agones-bot commented Jul 2, 2021

WeetA34 commented Jul 4, 2021

dzmitry-lahoda commented Jul 4, 2021 • edited Loading

dzmitry-lahoda commented Jul 4, 2021

dzmitry-lahoda commented Jul 4, 2021

WeetA34 commented Jul 4, 2021

WeetA34 commented Jul 4, 2021

dzmitry-lahoda commented Jul 4, 2021

WeetA34 commented Jul 4, 2021 • edited Loading

WeetA34 commented Jul 4, 2021

WeetA34 commented Jul 4, 2021

WeetA34 commented Jul 4, 2021

WeetA34 commented Jul 4, 2021

agones-bot commented Jul 4, 2021

WeetA34 commented Jul 4, 2021

agones-bot commented Jul 5, 2021

WeetA34 commented Jul 5, 2021

dzmitry-lahoda commented Jul 6, 2021 • edited Loading

WeetA34 commented Jul 6, 2021 • edited Loading

WeetA34 commented Jul 6, 2021

WeetA34 commented Jul 6, 2021 • edited Loading

WeetA34 commented Jul 6, 2021

WeetA34 commented Jul 6, 2021

markmandel commented Jul 8, 2021

WeetA34 commented Jul 9, 2021

agones-bot commented Jul 9, 2021

markmandel commented Jul 9, 2021 • edited Loading

google-oss-robot commented Jul 13, 2021

agones-bot commented Jul 13, 2021

WeetA34 commented Jul 1, 2021 •

edited

Loading

WeetA34 commented Jul 1, 2021 •

edited

Loading

dzmitry-lahoda commented Jul 4, 2021 •

edited

Loading

WeetA34 commented Jul 4, 2021 •

edited

Loading

dzmitry-lahoda commented Jul 6, 2021 •

edited

Loading

WeetA34 commented Jul 6, 2021 •

edited

Loading

WeetA34 commented Jul 6, 2021 •

edited

Loading

markmandel commented Jul 9, 2021 •

edited

Loading