Upgrade/go 1.15 #2167
Upgrade/go 1.15 #2167
Conversation
|
Build Succeeded 👏 Build Id: b03120d1-ce7b-4e6a-87bb-fc3474de97cd The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
|
@markmandel , I upgraded to go 1.15 instead and create another issue #2168 to address |
Makes sense to me 👍🏻 |
| @@ -96,6 +96,9 @@ EOF | |||
| # Add ca.crt to the allocator-tls-ca Secret | |||
| TLS_CA_VALUE=$(kubectl get secret allocator-tls -n agones-system -ojsonpath='{.data.ca\.crt}') | |||
| kubectl get secret allocator-tls-ca -o json -n agones-system | jq '.data["tls-ca.crt"]="'${TLS_CA_VALUE}'"' | kubectl apply -f - | |||
| echo $TLS_CA_VALUE | base64 -d > ca.crt | |||
There was a problem hiding this comment.
Are these changes only necessary once we make the next release (and are using go 1.15)? If so, they should be behind a feature gate: https://agones.dev/site/docs/contribute/#within-a-page
There was a problem hiding this comment.
I don't think they need to go behind a feature gate, as they will still work with the current release - and if people do it now, they don't have to do it later. So no issue as it is on my end.
There was a problem hiding this comment.
as long as they work with both old and new versions, sgtm.
There was a problem hiding this comment.
Go 1.15 no longer supports Common Name based certs for HTTPS without a specific flag. Adding SAN to the cert is the solution and it's also backward compatible.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cindy52, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
roberthbailey
added
area/build-tools
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Upgrade go version to 1.15.13 Go 1.15 no longer supports Common Name based certs for HTTPS without a specific flag. This PR includes adding SAN for all related certs and updating the doc to create a cert with SAN for allocation service.
Which issue(s) this PR fixes:
Closes #1899
Closes #2024