Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow FILE env variable for local SDK server #2174

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Looks like we forgot to bind the file argument flag to an environment variable input as well, even though we documented that you could also do this.

Well now you can!

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Looks like we forgot to bind the file argument flag to an environment
variable input as well, even though we documented that you could also do
this.

Well now you can!
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Jul 7, 2021
@markmandel markmandel requested a review from roberthbailey July 7, 2021 23:45
@google-cla google-cla bot added the cla: yes label Jul 7, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 27be49c5-ba4e-4489-b390-cb14fc8a0b44

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator Author

Flaky. Handholding helm because #2171 has CRD changes.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 0b51e864-ba16-43fb-b910-ee974672425e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2174/head:pr_2174 && git checkout pr_2174
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.16.0-c8e22f7

@markmandel markmandel merged commit fa951f7 into googleforgames:main Jul 8, 2021
@markmandel markmandel deleted the bug/sdk-server-file-env branch July 8, 2021 17:17
@markmandel markmandel added this to the 1.16.0 milestone Jul 8, 2021
@roberthbailey roberthbailey added the kind/bug These are bugs. label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cla: yes kind/bug These are bugs. kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants