Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in e2e/LogEvents #2350

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

I assumed that we always use the framework.Namespace value, but some tests don't!

Also made the error message more clear if the Event Search fails for any reason.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

I assumed that we always use the framework.Namespace value, but some
tests don't!

Also made the error message more clear if the Event `Search` fails for
any reason.
@markmandel markmandel added kind/bug These are bugs. area/tests Unit tests, e2e tests, anything to make sure things don't break labels Oct 29, 2021
@google-cla google-cla bot added the cla: yes label Oct 29, 2021
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: b4b16622-8429-4b7b-8d96-c9eee9bf6595

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 50e1e455-6172-4d2d-bcc4-d7dbbcf013ff

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: fe3141bf-4e09-45eb-847f-c9ba0f7beb94

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

--- FAIL: TestFleetAutoScalerRollingUpdate (366.15s)
    fleetautoscaler_test.go:236: 
        	Error Trace:	fleetautoscaler_test.go:236
        	Error:      	Should be true
        	Test:       	TestFleetAutoScalerRollingUpdate
        	Messages:   	Could not get AbleToScale status
    fleetautoscaler_test.go:297: 
        	Error Trace:	fleetautoscaler_test.go:297
        	Error:      	Received unexpected error:
        	            	New replicas should be not less than (target - maxUnavailable)
        	            	agones.dev/agones/test/e2e.TestFleetAutoScalerRollingUpdate.func3
        	            		/go/src/agones.dev/agones/test/e2e/fleetautoscaler_test.go:284
        	            	k8s.io/apimachinery/pkg/util/wait.runConditionWithCrashProtection
        	            		/go/src/agones.dev/agones/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:211
        	            	k8s.io/apimachinery/pkg/util/wait.pollImmediateInternal
        	            		/go/src/agones.dev/agones/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:445
        	            	k8s.io/apimachinery/pkg/util/wait.PollImmediate
        	            		/go/src/agones.dev/agones/vendor/k8s.io/apimachinery/pkg/util/wait/wait.go:441
        	            	agones.dev/agones/test/e2e.TestFleetAutoScalerRollingUpdate
        	            		/go/src/agones.dev/agones/test/e2e/fleetautoscaler_test.go:274
        	            	testing.tRunner
        	            		/usr/local/go/src/testing/testing.go:1259
        	            	runtime.goexit
        	            		/usr/local/go/src/runtime/asm_amd64.s:1581
        	Test:       	TestFleetAutoScalerRollingUpdate
FAIL

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: ce5cd046-5b64-464c-aa94-c9b05efa5638

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

sdk conformance:

make[2]: *** [run-sdk-conformance-no-build] Error 1

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: a7208878-3def-4d42-8ee0-2469687e616e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 149a829f-3beb-4f1d-bc81-e1fa19ee70c8

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

--- FAIL: TestGameServerSelfAllocate (47.58s)
    gameserver_test.go:482: Could not message GameServer: could not read response from the GameServer: read udp 192.168.10.6:57904->35.247.94.25:7463: i/o timeout

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 09fe8845-55be-4a1f-aa27-a31ad1355986

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2350/head:pr_2350 && git checkout pr_2350
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.19.0-e93ac82

@markmandel markmandel merged commit e8a60c0 into googleforgames:main Oct 30, 2021
@markmandel markmandel deleted the bug/log-events-namespace branch October 30, 2021 03:41
@roberthbailey roberthbailey added this to the 1.19.0 milestone Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break cla: yes kind/bug These are bugs. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants