-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in e2e/LogEvents #2350
Fix bug in e2e/LogEvents #2350
Conversation
I assumed that we always use the framework.Namespace value, but some tests don't! Also made the error message more clear if the Event `Search` fails for any reason.
Build Failed 😱 Build Id: b4b16622-8429-4b7b-8d96-c9eee9bf6595 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Build Failed 😱 Build Id: 50e1e455-6172-4d2d-bcc4-d7dbbcf013ff To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: fe3141bf-4e09-45eb-847f-c9ba0f7beb94 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Failed 😱 Build Id: ce5cd046-5b64-464c-aa94-c9b05efa5638 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
sdk conformance:
|
Build Failed 😱 Build Id: a7208878-3def-4d42-8ee0-2469687e616e To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😱 Build Id: 149a829f-3beb-4f1d-bc81-e1fa19ee70c8 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: 09fe8845-55be-4a1f-aa27-a31ad1355986 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind bug
What this PR does / Why we need it:
I assumed that we always use the framework.Namespace value, but some tests don't!
Also made the error message more clear if the Event
Search
fails for any reason.Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A