-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "kubectl explain" output for Agones CRDs #2423
Fix "kubectl explain" output for Agones CRDs #2423
Conversation
Build Failed 😱 Build Id: da0433da-bad7-4107-aff1-d0bd201d079b To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Thanks for your contribution! The automated tests failed because
Rather than editing it by hand, if you edit the helm files and then run |
2d32acf
to
0dbaa06
Compare
Build Succeeded 👏 Build Id: 46381256-5c11-4d76-8d3b-3ffe8aac7c0f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Thanks for your code review! @roberthbailey The generated install.yaml file was pushed and the build is just succeeded. Thank you. |
Oh that's neat! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just took this for a spin - looks good to me!
Build Succeeded 👏 Build Id: 548a7678-699e-478a-ac6c-d360b23f2783 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiwonaid, markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
To support "kubectl explain" command for Agones CRDs, some yaml values are added.
(kubernetes-admin-dev@dev) ☁ ~ kubectl explain pod KIND: Pod VERSION: v1 DESCRIPTION: Pod is a collection of containers that can run on a host. This resource is created by clients and scheduled onto hosts.
This is the result for the Fleet after applying this PR.
Which issue(s) this PR fixes:
Closes #1194
Special notes for your reviewer:
Hello.
For your information, I turned off my editor's auto-formatting features for the 'install/yaml/install.yaml', because I was not sure about that.