Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform test dependencies. #2425

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Fix for security alert:
https://github.com/googleforgames/agones/security/dependabot/test/terraform/go.sum/gopkg.in%2Fyaml.v2/open

This is a low risk alert, since it's on a rarely used test hardness, but good to provide an update and remove the alert by updating the core libraries.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

Fix for security alert:
https://github.com/googleforgames/agones/security/dependabot/test/terraform/go.sum/gopkg.in%2Fyaml.v2/open

This is a low risk alert, since it's on a rarely used test hardness, but
good to provide an update and remove the alert by updating the core
libraries.
@markmandel markmandel added area/security Issues pertaining to security area/tests Unit tests, e2e tests, anything to make sure things don't break labels Jan 11, 2022
@markmandel
Copy link
Collaborator Author

I thought I was marking the alert as "work in progress", but apparently I dismissed it 🤦🏻

New link:
https://github.com/googleforgames/agones/security/dependabot/test/terraform/go.sum/gopkg.in%2Fyaml.v2/closed

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c6cd545a-852d-407e-9963-84aa7ec4ef76

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2425/head:pr_2425 && git checkout pr_2425
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.20.0-a36734f

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Member

Merging during the feature freeze since this only affects the terraform test code and is a security fix.

@roberthbailey roberthbailey merged commit 9465361 into googleforgames:main Jan 12, 2022
@markmandel markmandel deleted the security/yaml branch January 12, 2022 22:44
@SaitejaTamma SaitejaTamma added this to the 1.20.0 milestone Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/security Issues pertaining to security area/tests Unit tests, e2e tests, anything to make sure things don't break lgtm size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants