Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Support gRPC without TLS #2472

Merged
merged 7 commits into from
Mar 1, 2022
Merged

Conversation

SpringMT
Copy link
Contributor

@SpringMT SpringMT commented Feb 9, 2022

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup

/kind documentation

/kind feature
/kind hotfix

What this PR does / Why we need it:
In this PR #2272, support gRPC without TLS.
So, remove the text that Only applicable to the REST API. It currently does not work for the gRPC API..

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: aec7066d-1680-4c0d-a342-a48d55621cbd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator

Thanks for the fix - we're in the process of getting the RC in, so will swing back around once that is complete.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: bc3f8cc2-ec41-4249-9745-7ea34b7ee1ed

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2472/head:pr_2472 && git checkout pr_2472
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-78f157d

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 20015215-5bf7-46a2-b00b-49c290eed053

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2472/head:pr_2472 && git checkout pr_2472
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.21.0-d6a915e

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 3504d2db-528d-4520-8bd2-7ff6fdd90937

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 1a7877a0-0568-470d-b636-68e879f42548

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2472/head:pr_2472 && git checkout pr_2472
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-bdd8154

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4894ea8b-24b2-44b6-9ba1-2f2888e77db3

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2472/head:pr_2472 && git checkout pr_2472
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-98ab3d7

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8e4267a0-6ece-4f79-b465-73120c0c892b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2472/head:pr_2472 && git checkout pr_2472
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-d414c74

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey, SpringMT

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey roberthbailey merged commit 571b2fd into googleforgames:main Mar 1, 2022
@roberthbailey roberthbailey added the kind/cleanup Refactoring code, fixing up documentation, etc label Mar 1, 2022
@SaitejaTamma SaitejaTamma added this to the 1.22.0 milestone Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants