Add NodePort to the helm template for agones-allocator service

[jiwonaid]

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug
/kind cleanup
/kind documentation

/kind feature

/kind hotfix

What this PR does / Why we need it:

To support type: NodePort for agones dev environment.

Which issue(s) this PR fixes:

Closes #1699

Special notes for your reviewer:

Hello, this is my second pull request.

May I freely select between normal issues and good first issue? Is it okay to solve multiple good first issues?

[jiwonaid]

This seems like a straightforward extension to the helm chart, if someone would like to contribute a PR to implement it I'd be happy to review it.

/cc @roberthbailey

[agones-bot]

Build Failed 😱

Build Id: acdc7973-84ca-4a21-8eac-fc04204783c8

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[agones-bot]

Build Failed 😱

Build Id: fac8cc61-3d53-4f58-81a0-2acd23a10173

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[markmandel]

Looks like a flake, will run again when it gets fixed. #2479

[roberthbailey]

Two thoughts about this.

1. Setting this to 0 seems like a bad default. If we are going to set it to an example value, it seems like it should be a port that would actually work if you just changed the serviceType above.
2. This file doesn't really have many comments, but it seems like if we are going to include a value here it is worth adding a comment that it will only be used if the service type is set to NodePort.

[jiwonaid]

Thank you for the feedback.

1. I think it is okay to use 0. When I type kubectl create service nodeport --help, the nodePort parameter is described like this.

   (docker-desktop) ☁  ~  kubectl create service nodeport --help
   --node-port=0: Port used to expose the service on each node in a cluster.

   This is because v1.ServiceSpec.ServicePort is using int32.

   https://github.com/kubernetes/api/blob/b8c40e080bc5e830097df540d4ef804034cb5bdb/core/v1/types.go#L4536

   I found some examples that using NodePort: 0 in the test code of kubectl with expectErr: false.

   https://github.com/kubernetes/kubectl/blob/c26d922e2ead95fb4850c73c3c41027da40f3e0e/pkg/cmd/create/create_service_test.go#L204-L221

   It is a good idea to use an example NodePort with the default range of 30000-32767. However, it could make an error if the port is already taken by another Service.

2. Comments are added right behind the nodePort.

[agones-bot]

Build Failed 😱

Build Id: 570cbc55-3a10-434a-884a-d2d15a3ed182

• Cloud Build view
• Cloud Build log download

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

[roberthbailey]

Failed on push-images:

received unexpected HTTP status: 503 Service Unavailable
make: *** [Makefile:442: push-ping-image] Error 1

[google-oss-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiwonaid, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[google-oss-prow]

New changes are detected. LGTM label has been removed.

[agones-bot]

Build Succeeded 👏

Build Id: 964ed8a6-a7f8-4dfd-bcb3-b2da9e95b46e

The following development artifacts have been built, and will exist for the next 30 days:

• image: gcr.io/agones-images/agones-controller:1.22.0-669e992
• image: gcr.io/agones-images/agones-ping:1.22.0-669e992
• Linux C++ SDK (build): agonessdk-1.22.0-669e992-linux-arch_64.tar.gz
• SDK Server: agonessdk-server-1.22.0-669e992.zip

A preview of the website (the last 30 builds are retained):

• https://669e992-dot-preview-dot-agones-images.appspot.com/

To install this version:

• git fetch https://github.com/googleforgames/agones.git pull/2476/head:pr_2476 && git checkout pr_2476
• helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.22.0-669e992