Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update everything to simple-gameserver:0.12 #2540

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Update everything to simple-gameserver:0.12 #2540

merged 2 commits into from
Apr 12, 2022

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

This updates everything to use the updated simple-game-server (0.12)

Which issue(s) this PR fixes:

Unblocks #2503

Special notes for your reviewer:

N/A

@markmandel
Update everything to simple-gameserver:0.12
c82d783 
This updates everything to use the updated
simple-game-server.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/tests Unit tests, e2e tests, anything to make sure things don't break labels Apr 11, 2022
@google-oss-prow google-oss-prow bot requested review from aLekSer and dzlier-gcp April 11, 2022 22:20
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 2d58e35a-848b-4157-bc6f-740ce99d9413

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member 

--- FAIL: TestFleetAutoscalerTLSWebhook (316.74s)
    framework.go:311: 
        	Error Trace:	framework.go:311
        	            				fleetautoscaler_test.go:701
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestFleetAutoscalerTLSWebhook
        	Messages:   	error waiting for fleet condition on fleet: simple-fleet-z64hz
FAIL

roberthbailey
roberthbailey approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@roberthbailey roberthbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good. I think the test failure is a flake but please verify before merging.

@google-oss-prow google-oss-prow bot added the lgtm label Apr 11, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@markmandel
Copy link
Collaborator Author

Testing locally - I think the cert expired:

  Warning  FleetAutoscaler  92s (x13 over 2m8s)    fleetautoscaler-controller  (combined from similar events): Error calculating desired fleet size on FleetAutoscaler simple-fleet-zhjct-autoscaler. Error: Post "https://autoscaler-tls-service.default.svc:8000/scale": x509: certificate has expired or is not yet valid: current time 2022-04-12T00:26:31Z is after 2022-04-09T13:38:39Z

I wonder if we can dynamically generate certs on each run.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: f5e10a2f-ba0f-4eda-9977-0d69eb03bfff

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@google-oss-prow google-oss-prow bot removed the lgtm label Apr 12, 2022
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ac07e378-452e-47c0-956e-a24387a486eb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2540/head:pr_2540 && git checkout pr_2540
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-05745a0

@markmandel markmandel merged commit e7fa0af into googleforgames:main Apr 12, 2022
@markmandel markmandel deleted the update/simple-gameserver branch April 12, 2022 17:18
Thiryn pushed a commit to Thiryn/agones that referenced this pull request Apr 25, 2022
@markmandel @roberthbailey
Update everything to simple-gameserver:0.12 (googleforgames#2540)
e2a237c 
This updates everything to use the updated
simple-game-server.

Co-authored-by: Robert Bailey <robertbailey@google.com>
@SaitejaTamma SaitejaTamma added this to the 1.23.0 milestone May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

@aLekSer aLekSer Awaiting requested review from aLekSer

@dzlier-gcp dzlier-gcp Awaiting requested review from dzlier-gcp

Assignees

@roberthbailey roberthbailey

Labels
approved area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc size/M
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
4 participants
@markmandel @agones-bot @roberthbailey @SaitejaTamma