Remove broken links to unblock CI #2573

roberthbailey · 2022-05-11T06:40:04Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it: Remove broken links to unblock CI

Which issue(s) this PR fixes:

Closes #

Special notes for your reviewer:

agones-bot · 2022-05-11T07:25:51Z

Build Failed 😱

Build Id: 449a138b-c80b-45b0-8c08-e37cd7c00d50

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

roberthbailey · 2022-05-11T08:06:16Z

The link checker seems to have found a few other links to complain about:

Html Test: Attempt 20
htmltest started at 07:24:38 on /tmp/website
========================================================================
site/docs/installation/creating-cluster/minikube/index.html
  Non-OK status: 403 --- site/docs/installation/creating-cluster/minikube/index.html --> https://blog.thepolyglotprogrammer.com/setting-up-kubernetes-on-wsl-to-work-with-minikube-on-windows-10-90dac3c72fa1
site/docs/installation/creating-cluster/eks/index.html
  Non-OK status: 403 --- site/docs/installation/creating-cluster/eks/index.html --> https://itnext.io/kubernetes-is-hard-why-eks-makes-it-easier-for-network-and-security-architects-ea6d8b2ca965
========================================================================
✘✘✘ failed in 894.757052ms

agones-bot · 2022-05-11T08:39:20Z

Build Succeeded 👏

Build Id: 83894e72-c140-4a70-9e4e-043bb0128d7b

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.23.0-9ed8cba-amd64
image: gcr.io/agones-images/agones-ping:1.23.0-9ed8cba
Linux C++ SDK (build): agonessdk-1.23.0-9ed8cba-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.23.0-9ed8cba.zip

A preview of the website (the last 30 builds are retained):

https://9ed8cba-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2573/head:pr_2573 && git checkout pr_2573
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.23.0-9ed8cba-amd64

pooneh-m · 2022-05-11T16:52:07Z

site/content/en/blog/releases/1.12.0.md

@@ -31,7 +31,7 @@ Check the <a href="https://github.com/googleforgames/agones/tree/release-1.12.0"
 - Move ContainerPortAllocation to Stable [\#1961](https://github.com/googleforgames/agones/pull/1961) ([markmandel](https://github.com/markmandel))
 - CRD OpenAPI Spec for ObjectMeta & PodTemplateSpec [\#1956](https://github.com/googleforgames/agones/pull/1956) ([markmandel](https://github.com/markmandel))
 - Add a "why" section for the Allocator Service documentation [\#1953](https://github.com/googleforgames/agones/pull/1953) ([markmandel](https://github.com/markmandel))
- Add nodeSelector property to Agones helm chart for Allocator [\#1946](https://github.com/googleforgames/agones/pull/1946) ([josephbmanley](https://github.com/josephbmanley))
+- Add nodeSelector property to Agones helm chart for Allocator [\#1946](https://github.com/googleforgames/agones/pull/1946) (josephbmanley)


Remove (josephbmanley) as well?

pooneh-m · 2022-05-11T16:52:25Z

site/content/en/blog/releases/1.12.0-rc.md

@@ -31,7 +31,7 @@ Check the <a href="https://github.com/googleforgames/agones/tree/release-1.12.0-
 - Move ContainerPortAllocation to Stable [\#1961](https://github.com/googleforgames/agones/pull/1961) ([markmandel](https://github.com/markmandel))
 - CRD OpenAPI Spec for ObjectMeta & PodTemplateSpec [\#1956](https://github.com/googleforgames/agones/pull/1956) ([markmandel](https://github.com/markmandel))
 - Add a "why" section for the Allocator Service documentation [\#1953](https://github.com/googleforgames/agones/pull/1953) ([markmandel](https://github.com/markmandel))
- Add nodeSelector property to Agones helm chart for Allocator [\#1946](https://github.com/googleforgames/agones/pull/1946) ([josephbmanley](https://github.com/josephbmanley))
+- Add nodeSelector property to Agones helm chart for Allocator [\#1946](https://github.com/googleforgames/agones/pull/1946) (josephbmanley)


remove (josephbmanley)?

pooneh-m

Approving to unblock the CL. Please see my comments.

pooneh-m · 2022-05-11T16:53:48Z

site/content/en/blog/releases/1.1.0-rc.md

@@ -43,7 +43,7 @@ Check the <a href="https://github.com/googleforgames/agones/tree/release-1.1.0-r
 **Security fixes:**

 - Ran `npm audit fix` to update package dependencies. [\#1097](https://github.com/googleforgames/agones/pull/1097) ([roberthbailey](https://github.com/roberthbailey))
- Bump eslint-utils from 1.4.0 to 1.4.2 in /sdks/nodejs [\#1014](https://github.com/googleforgames/agones/pull/1014) ([dependabot[bot]](https://github.com/apps/dependabot))
+- Bump eslint-utils from 1.4.0 to 1.4.2 in /sdks/nodejs [\#1014](https://github.com/googleforgames/agones/pull/1014) (dependabot[bot])


Please remove (dependabot[bot]) as well.

google-oss-prow · 2022-05-11T16:54:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [pooneh-m,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Remove broken links to unblock CI.

e5ba21a

roberthbailey added the kind/cleanup Refactoring code, fixing up documentation, etc label May 11, 2022

google-oss-prow bot added the size/S label May 11, 2022

google-oss-prow bot requested review from cyriltovena and pooneh-m May 11, 2022 06:40

google-oss-prow bot added the approved label May 11, 2022

roberthbailey mentioned this pull request May 11, 2022

ensure context is set before spawning goroutines using it #2569

Merged

Skip link checking for a couple more links.

9ed8cba

pooneh-m reviewed May 11, 2022

View reviewed changes

pooneh-m approved these changes May 11, 2022

View reviewed changes

google-oss-prow bot assigned pooneh-m May 11, 2022

google-oss-prow bot added the lgtm label May 11, 2022

roberthbailey merged commit 9d669d5 into googleforgames:main May 11, 2022

roberthbailey added this to the 1.23.0 milestone May 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove broken links to unblock CI #2573

Remove broken links to unblock CI #2573

roberthbailey commented May 11, 2022

agones-bot commented May 11, 2022

roberthbailey commented May 11, 2022

agones-bot commented May 11, 2022

pooneh-m May 11, 2022

pooneh-m May 11, 2022

pooneh-m left a comment

pooneh-m May 11, 2022

google-oss-prow bot commented May 11, 2022

Remove broken links to unblock CI #2573

Remove broken links to unblock CI #2573

Conversation

roberthbailey commented May 11, 2022

agones-bot commented May 11, 2022

roberthbailey commented May 11, 2022

agones-bot commented May 11, 2022

pooneh-m May 11, 2022

Choose a reason for hiding this comment

pooneh-m May 11, 2022

Choose a reason for hiding this comment

pooneh-m left a comment

Choose a reason for hiding this comment

pooneh-m May 11, 2022

Choose a reason for hiding this comment

google-oss-prow bot commented May 11, 2022