Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated preferred & required to selectors in Player Capacity docs #2577

Merged
merged 2 commits into from
May 12, 2022

Conversation

JJhuk
Copy link
Contributor

@JJhuk JJhuk commented May 12, 2022

What type of PR is this?
/kind documentation

What this PR does / Why we need it:
Because preferred and required fields are deprecated in agones, so I changed them to selectors

Which issue(s) this PR fixes:

Closes #2570

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: be7b8556-8d6c-4c5d-860f-4a482015f8dd

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e94b38be-c034-46f9-9d08-ed4db6ac1073

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2577/head:pr_2577 && git checkout pr_2577
  • helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-464f74d-amd64

@google-oss-prow google-oss-prow bot added the lgtm label May 12, 2022
@roberthbailey roberthbailey merged commit 76ee8f9 into googleforgames:main May 12, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JJhuk, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JJhuk JJhuk deleted the update-player-capacity-docs branch May 13, 2022 02:08
@SaitejaTamma SaitejaTamma added this to the 1.24.0 milestone Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants