Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updateing debian image to bullseye/Part-2 #2585

Closed

Conversation

SaitejaTamma
Copy link
Contributor

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking

/kind bug

/kind cleanup
/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it: it is a part of #2224

Which issue(s) this PR fixes:

@SaitejaTamma SaitejaTamma added the kind/bug These are bugs. label May 18, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 51074758-5bd0-46b3-8206-03bf4d6b5b36

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator

I see:

-- Install configuration: "Release"
cd /go/src/agones.dev/agones/sdks/cpp//.build/clang-format && cmake . -DAGONES_SILENT_OUTPUT=ON
CMake Error at CMakeLists.txt:28 (_message):
  clang-format code style check failed for: sdks/cpp/src/agones/sdk.cc
Call Stack (most recent call first):
  CMakeLists.txt:72 (message)


-- Configuring incomplete, errors occurred!
See also "/go/src/agones.dev/agones/sdks/cpp/.build/clang-format/CMakeFiles/CMakeOutput.log".

When you run this locally, what is output in the log file?

@SaitejaTamma SaitejaTamma added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jun 14, 2022
@markmandel
Copy link
Collaborator

The CI system will run all SDK tests, but to test locally, the easiest might be to run just one, so do a:

make run-sdk-conformance-test-node to run just the node sdk tests, forcing the images in this PR to compile and run.

Then we can look at "/go/src/agones.dev/agones/sdks/cpp/.build/clang-format/CMakeFiles/CMakeOutput.log". to see if we can see what is failing in that log file.

@SaitejaTamma SaitejaTamma removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jun 22, 2022
@markmandel
Copy link
Collaborator

Since this seems to be blocked for now, should be close this PR?

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SaitejaTamma
Once this PR has been reviewed and has the lgtm label, please assign markmandel for approval by writing /assign @markmandel in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 7ea2c396-45c3-4e8c-a612-6a85f7efe3b9

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Collaborator

Failed again - looks like I'll end up taking this over.

  Determining projects to restore...
  Restored /go/src/agones.dev/agones/sdks/csharp/sdk/csharp-sdk.csproj (in 1.9 sec).
  csharp-sdk -> /go/src/agones.dev/agones/sdks/csharp/sdk/bin/Release/netstandard2.0/AgonesSDK.dll
  csharp-sdk -> /go/src/agones.dev/agones/sdks/csharp/sdk/bin/Release/netstandard2.0/publish/
Install the project...
-- Install configuration: "Release"
cd /go/src/agones.dev/agones/sdks/cpp//.build/clang-format && cmake . -DAGONES_SILENT_OUTPUT=ON
CMake Error at CMakeLists.txt:28 (_message):
  clang-format code style check failed for: sdks/cpp/src/agones/sdk.cc
Call Stack (most recent call first):
  CMakeLists.txt:72 (message)

@SaitejaTamma SaitejaTamma added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 6, 2022
@SaitejaTamma SaitejaTamma removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Sep 14, 2022
@mangalpalli mangalpalli added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Oct 18, 2022
@markmandel
Copy link
Collaborator

Pretty sure I've got a fix for this, so closing, and will replace shortly.

@markmandel markmandel closed this Oct 19, 2022
@markmandel markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants