supertuxcart version update-1.3 #2608

SaitejaTamma · 2022-06-03T04:20:44Z

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

Which issue(s) this PR fixes:

Closes #2546

Special notes for your reviewer:

agones-bot · 2022-06-03T04:45:54Z

Build Succeeded 👏

Build Id: 3e26ca15-727a-444f-b5f8-54ac00061d51

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.24.0-781e8a1-amd64
image: gcr.io/agones-images/agones-controller:1.24.0-781e8a1-arm64
image: gcr.io/agones-images/agones-ping:1.24.0-781e8a1-amd64
image: gcr.io/agones-images/agones-ping:1.24.0-781e8a1-arm64
Linux C++ SDK (build): agonessdk-1.24.0-781e8a1-arm64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.24.0-781e8a1-arm64.zip

A preview of the website (the last 30 builds are retained):

https://781e8a1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2608/head:pr_2608 && git checkout pr_2608
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-781e8a1-amd64

markmandel · 2022-06-03T19:44:33Z

As per the ticket, can you also:

We will need to ensure is in the configuration file (see link below for config file documentation), such that we can connect AI bots from outside the cluster/node (otherwise it only accepts connections from localhost).

Also, please increment the example image tag.

agones-bot · 2022-06-03T20:31:02Z

Build Succeeded 👏

Build Id: e5924366-344e-45d2-aa17-be83e6d1e1ed

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.24.0-8d2c9a3-amd64
image: gcr.io/agones-images/agones-controller:1.24.0-8d2c9a3-arm64
image: gcr.io/agones-images/agones-ping:1.24.0-8d2c9a3-amd64
image: gcr.io/agones-images/agones-ping:1.24.0-8d2c9a3-arm64
Linux C++ SDK (build): agonessdk-1.24.0-8d2c9a3-arm64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.24.0-8d2c9a3-arm64.zip

A preview of the website (the last 30 builds are retained):

https://8d2c9a3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2608/head:pr_2608 && git checkout pr_2608
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-8d2c9a3-amd64

agones-bot · 2022-06-06T17:01:42Z

Build Succeeded 👏

Build Id: cbb01c89-57b2-40b2-9e3f-95c282c780ff

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.24.0-77015c3-amd64
image: gcr.io/agones-images/agones-controller:1.24.0-77015c3-arm64
image: gcr.io/agones-images/agones-ping:1.24.0-77015c3-amd64
image: gcr.io/agones-images/agones-ping:1.24.0-77015c3-arm64
Linux C++ SDK (build): agonessdk-1.24.0-77015c3-arm64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.24.0-77015c3-arm64.zip

A preview of the website (the last 30 builds are retained):

https://77015c3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2608/head:pr_2608 && git checkout pr_2608
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.24.0-77015c3-amd64

examples/supertuxkart/Dockerfile

examples/supertuxkart/server_config.xml

markmandel · 2022-06-09T16:48:01Z

Gah! Thank you for the reminder to do PR reviews. Will do this today!

agones-bot · 2022-06-09T17:03:08Z

Build Succeeded 👏

Build Id: f1bdceb7-517a-4f47-9fc6-64784a1bfa91

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.24.0-2f6dd7a-amd64
image: gcr.io/agones-images/agones-controller:1.24.0-2f6dd7a-arm64
image: gcr.io/agones-images/agones-ping:1.24.0-2f6dd7a-amd64
image: gcr.io/agones-images/agones-ping:1.24.0-2f6dd7a-arm64
Linux C++ SDK (build): agonessdk-1.24.0-2f6dd7a-arm64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.24.0-2f6dd7a-arm64.zip

A preview of the website (the last 30 builds are retained):

https://2f6dd7a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2608/head:pr_2608 && git checkout pr_2608
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-2f6dd7a-amd64

examples/supertuxkart/server_config.xml

markmandel · 2022-06-09T17:12:46Z

examples/supertuxkart/Dockerfile

-    && make -j$(nproc)
+RUN tar -xf SuperTuxKart-1.3-linux-64bit.tar.xz
+RUN rm -rf SuperTuxKart-1.3-linux-64bit.tar.xz
+RUN ./SuperTuxKart-1.3-linux-64bit/run_game.sh


I just tried to build this image, and noticed that you seem to be running the game here (which fails). I'm not 100% sure why?

examples/supertuxkart/Dockerfile

agones-bot · 2022-06-13T21:20:08Z

Build Succeeded 👏

Build Id: 9c7749a4-efd0-4da9-bc63-1cf71ee79a84

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.24.0-8aab7be-amd64
image: gcr.io/agones-images/agones-controller:1.24.0-8aab7be-arm64
image: gcr.io/agones-images/agones-ping:1.24.0-8aab7be-amd64
image: gcr.io/agones-images/agones-ping:1.24.0-8aab7be-arm64
Linux C++ SDK (build): agonessdk-1.24.0-8aab7be-arm64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.24.0-8aab7be-arm64.zip

A preview of the website (the last 30 builds are retained):

https://8aab7be-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2608/head:pr_2608 && git checkout pr_2608
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-8aab7be-amd64

markmandel

Got some nits inline.

Also looks like it fails on running the actual image:

➜  supertuxkart git:(pr/supertuxcart/upgrade) docker run --network=host gcr.io/agones-images/supertuxkart-example:0.5
[wrapper] 2022/06/13 22:56:58 Connecting to Agones with the SDK
[wrapper] 2022/06/13 22:56:58 Starting health checking
[wrapper] 2022/06/13 22:56:58 Starting wrapper for SuperTuxKart
[wrapper] 2022/06/13 22:56:58 Command being run for SuperTuxKart server: ./cmake_build/bin/supertuxkart --server-config=/home/supertuxkart/stk-code/server_config.xml
[wrapper] 2022/06/13 22:56:58 error starting cmd: fork/exec ./cmake_build/bin/supertuxkart: no such file or directory

Looks like some paths will need to be fixed now the file it downloaded rather than compiled.

examples/supertuxkart/Dockerfile

Co-authored-by: Mark Mandel <markmandel@google.com>

agones-bot · 2022-06-13T23:17:40Z

Build Failed 😱

Build Id: f3035bd1-3285-487f-b76f-a7f8ad434ac6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-06-14T19:19:20Z

Build Succeeded 👏

Build Id: 747498fe-3636-4aad-8ed6-7c54c2a56e14

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.24.0-1d9939f-amd64
image: gcr.io/agones-images/agones-controller:1.24.0-1d9939f-arm64
image: gcr.io/agones-images/agones-ping:1.24.0-1d9939f-amd64
image: gcr.io/agones-images/agones-ping:1.24.0-1d9939f-arm64
Linux C++ SDK (build): agonessdk-1.24.0-1d9939f-arm64-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.24.0-1d9939f-arm64.zip

A preview of the website (the last 30 builds are retained):

https://1d9939f-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2608/head:pr_2608 && git checkout pr_2608
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-1d9939f-amd64

markmandel · 2022-06-16T15:44:39Z

I'll build this and do a test run with it, and if it's good, then we can merge 👍🏻

markmandel · 2022-06-17T20:12:28Z

I just took this for a spin, but unfortunately it didn't work:

➜  supertuxkart git:(pr/supertuxcart/upgrade) make build
docker build -f /home/mark/workspace/agones/examples/supertuxkart//Dockerfile --tag=gcr.io/agones-images/supertuxkart-example:0.5 .
Sending build context to Docker daemon  72.19kB
Step 1/21 : FROM golang:1.17.2 as go-builder
 ---> 9f8b89ee4475
Step 2/21 : WORKDIR /go/src/supertuxkart
 ---> Using cache
 ---> e455f84d1d07
Step 3/21 : COPY main.go .
 ---> Using cache
 ---> b4b70659f19e
Step 4/21 : COPY go.mod .
 ---> Using cache
 ---> 737e7e30debb
Step 5/21 : RUN go mod tidy
 ---> Using cache
 ---> 262a309513d7
Step 6/21 : RUN go build -o wrapper .
 ---> Using cache
 ---> a1c92aa8d83d
Step 7/21 : FROM debian:bullseye
 ---> 4eacea30377a
Step 8/21 : RUN apt update && apt-get install -y  wget xz-utils
 ---> Using cache
 ---> 6112f9c444bf
Step 9/21 : RUN wget --quiet https://github.com/supertuxkart/stk-code/releases/download/1.3/SuperTuxKart-1.3-linux-64bit.tar.xz && tar -xf SuperTuxKart-1.3-linux-64bit.tar.xz && rm -rf SuperTuxKart-1.3-linux-64bit.tar.xz
 ---> Using cache
 ---> 6f3976bc76bd
Step 10/21 : RUN tar -xf SuperTuxKart-1.3-linux-64bit.tar.xz
 ---> Running in 93eb3ad5b9ad
tar: SuperTuxKart-1.3-linux-64bit.tar.xz: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
The command '/bin/sh -c tar -xf SuperTuxKart-1.3-linux-64bit.tar.xz' returned a non-zero code: 2
make: *** [Makefile:41: build] Error 2

examples/supertuxkart/Dockerfile

google-oss-prow · 2022-06-18T00:37:30Z

@KishoreNamala: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Kishore <kishorenamala@gmail.com>

agones-bot · 2022-06-20T20:43:20Z

Build Failed 😱

Build Id: 875468c7-3925-40f6-8288-29d1550174c2

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2022-06-21T15:17:17Z

Build Failed 😱

Build Id: 339486c7-6611-465c-ae0c-0547013b8672

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2022-06-21T22:39:15Z

Just attempted to run the image again, and unfortunately got the same issue as above:

➜  supertuxkart git:(pr/supertuxcart/upgrade) docker run --network=host gcr.io/agones-images/supertuxkart-example:0.5
[wrapper] 2022/06/21 22:37:11 Connecting to Agones with the SDK
[wrapper] 2022/06/21 22:37:11 Starting health checking
[wrapper] 2022/06/21 22:37:11 Starting wrapper for SuperTuxKart
[wrapper] 2022/06/21 22:37:11 Command being run for SuperTuxKart server: ./cmake_build/bin/supertuxkart --server-config=/home/supertuxkart/stk-code/server_config.xml
[wrapper] 2022/06/21 22:37:11 error starting cmd: fork/exec ./cmake_build/bin/supertuxkart: no such file or directory

If you want to test locally, you can use a local sdk instance (hence me using the host networking on Docker, so it can connect).

agones-bot · 2022-06-30T18:23:36Z

Build Failed 😱

Build Id: b98465d7-8280-465b-bcc2-753b68b7528d

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

markmandel · 2022-07-03T18:21:05Z

========================================================================
site/docs/prerequisite-knowledge/index.html
  Non-OK status: 404 --- site/docs/prerequisite-knowledge/index.html --> https://www.katacoda.com/courses/docker
  Non-OK status: 404 --- site/docs/prerequisite-knowledge/index.html --> https://www.katacoda.com/courses/kubernetes
========================================================================

If you rebase against main, this will go away.

agones-bot · 2022-07-04T17:51:53Z

Build Succeeded 👏

Build Id: 6d8b35db-cfb4-4f13-92ea-0b7cb89b9955

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://84f99a9-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2608/head:pr_2608 && git checkout pr_2608
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.25.0-84f99a9-amd64

markmandel · 2022-07-06T21:31:50Z

So I was running through dependencies via: https://packages.debian.org/search?suite=bullseye&arch=amd64&mode=exactfilename&searchon=contents&keywords=libcurl.so (and then rinse-and-repeating until there were no more dependency issues, and tracking down some other ones, and looking at dependencies of the apt repo verison, and some general googling), and I ended up with:

RUN apt-get install -y libcurl4-gnutls-dev libopenal1 libsqlite3-dev libopenal1

But I got stuck with this dependency:

/home/supertuxkart/SuperTuxKart-1.3-linux-64bit/bin/supertuxkart: error while loading shared libraries: libmbedcrypto.so.6: cannot open shared object file: No such file or directory

Which does not seem to exist in bullseye https://packages.debian.org/search?suite=bullseye&section=all&arch=any&searchon=contents&keywords=libmbedcrypto.so.6).

So here's my final suggestion - let's use Debain testing (bookwork) as the image, and we can install Supertuxkart 1.3 through apt rather than downloading, and most of our problems should go away!

For an example image, I don't think it matters if we're using a pre-release version of Debian (I use it as my daily usage anyway),and the image will eventually become stable anyway.

How does that sound?

The other idea is to drop an issue on https://github.com/supertuxkart/stk-code and see if they can help with how to run on Debian bullseye.

markmandel · 2022-07-13T22:40:57Z

Just noticing that in the apt repository for Debian bookworm has both amd64 and arm64 - so in theory, it should be quite easy to multi-arch this example, as you could just build for both at the same time.

agones-bot · 2022-07-15T16:21:41Z

Build Succeeded 👏

Build Id: 3012d223-0aba-41be-bfe0-19537b331264

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://edee8a0-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2608/head:pr_2608 && git checkout pr_2608
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.25.0-edee8a0-amd64

examples/supertuxkart/Dockerfile

Co-authored-by: Mark Mandel <markmandel@google.com>

agones-bot · 2022-07-15T22:06:52Z

Build Succeeded 👏

Build Id: 3ffd4237-af34-414f-aa66-ff9ca65524fb

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

https://3fcfdb5-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/2608/head:pr_2608 && git checkout pr_2608
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.25.0-3fcfdb5-amd64

markmandel

Tested, and it looks good!

google-oss-prow · 2022-07-15T22:13:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, SaitejaTamma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

supertuxcart version update-1.3

781e8a1

SaitejaTamma added kind/cleanup Refactoring code, fixing up documentation, etc area/examples Examples. Usually found in the `examples` directory labels Jun 3, 2022

google-oss-prow bot added the size/S label Jun 3, 2022

google-oss-prow bot requested review from pooneh-m and roberthbailey June 3, 2022 04:21

updated the tage value

8d2c9a3

updated config file

77015c3

roberthbailey reviewed Jun 6, 2022

View reviewed changes

examples/supertuxkart/Dockerfile Outdated Show resolved Hide resolved

examples/supertuxkart/server_config.xml Outdated Show resolved Hide resolved

examples/supertuxkart/server_config.xml Outdated Show resolved Hide resolved

updated code

2f6dd7a

google-oss-prow bot added size/M and removed size/S labels Jun 9, 2022

markmandel reviewed Jun 9, 2022

View reviewed changes

updated to single image

8aab7be

markmandel reviewed Jun 13, 2022

View reviewed changes

examples/supertuxkart/Dockerfile Outdated Show resolved Hide resolved

examples/supertuxkart/Dockerfile Outdated Show resolved Hide resolved

examples/supertuxkart/Dockerfile Outdated Show resolved Hide resolved

SaitejaTamma and others added 2 commits June 13, 2022 19:00

Update examples/supertuxkart/Dockerfile

dc4629f

Co-authored-by: Mark Mandel <markmandel@google.com>

Update examples/supertuxkart/Dockerfile

24f7cae

Co-authored-by: Mark Mandel <markmandel@google.com>

update

1d9939f

SaitejaTamma added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jun 14, 2022

KishoreNamala suggested changes Jun 18, 2022

View reviewed changes

examples/supertuxkart/Dockerfile Outdated Show resolved Hide resolved

examples/supertuxkart/Dockerfile Outdated Show resolved Hide resolved

SaitejaTamma and others added 2 commits June 20, 2022 16:28

Update examples/supertuxkart/Dockerfile

70c5bcf

Co-authored-by: Kishore <kishorenamala@gmail.com>

Update examples/supertuxkart/Dockerfile

54064b0

Co-authored-by: Kishore <kishorenamala@gmail.com>

SaitejaTamma removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Jun 22, 2022

new changes

36ca9d2

Merge branch 'main' into supertuxcart/upgrade

84f99a9

SaitejaTamma added 2 commits July 15, 2022 08:54

using apt for supertuxkart

89b7fe8

Merge branch 'main' into supertuxcart/upgrade

edee8a0

markmandel reviewed Jul 15, 2022

View reviewed changes

examples/supertuxkart/Dockerfile Outdated Show resolved Hide resolved

Update examples/supertuxkart/Dockerfile

3fcfdb5

Co-authored-by: Mark Mandel <markmandel@google.com>

markmandel approved these changes Jul 15, 2022

View reviewed changes

google-oss-prow bot assigned markmandel Jul 15, 2022

google-oss-prow bot added the lgtm label Jul 15, 2022

markmandel merged commit c9efc7d into googleforgames:main Jul 15, 2022

google-oss-prow bot added the approved label Jul 15, 2022

markmandel added this to the 1.25.0 milestone Jul 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

supertuxcart version update-1.3 #2608

supertuxcart version update-1.3 #2608

SaitejaTamma commented Jun 3, 2022

agones-bot commented Jun 3, 2022

markmandel commented Jun 3, 2022

agones-bot commented Jun 3, 2022

agones-bot commented Jun 6, 2022

markmandel commented Jun 9, 2022

agones-bot commented Jun 9, 2022

markmandel Jun 9, 2022

agones-bot commented Jun 13, 2022

markmandel left a comment

agones-bot commented Jun 13, 2022

agones-bot commented Jun 14, 2022

markmandel commented Jun 16, 2022

markmandel commented Jun 17, 2022

google-oss-prow bot commented Jun 18, 2022

agones-bot commented Jun 20, 2022

agones-bot commented Jun 21, 2022

markmandel commented Jun 21, 2022

agones-bot commented Jun 30, 2022

markmandel commented Jul 3, 2022

agones-bot commented Jul 4, 2022

markmandel commented Jul 6, 2022

markmandel commented Jul 13, 2022

agones-bot commented Jul 15, 2022

agones-bot commented Jul 15, 2022

markmandel left a comment

google-oss-prow bot commented Jul 15, 2022

supertuxcart version update-1.3 #2608

supertuxcart version update-1.3 #2608

Conversation

SaitejaTamma commented Jun 3, 2022

agones-bot commented Jun 3, 2022

markmandel commented Jun 3, 2022

agones-bot commented Jun 3, 2022

agones-bot commented Jun 6, 2022

markmandel commented Jun 9, 2022

agones-bot commented Jun 9, 2022

markmandel Jun 9, 2022

Choose a reason for hiding this comment

agones-bot commented Jun 13, 2022

markmandel left a comment

Choose a reason for hiding this comment

agones-bot commented Jun 13, 2022

agones-bot commented Jun 14, 2022

markmandel commented Jun 16, 2022

markmandel commented Jun 17, 2022

google-oss-prow bot commented Jun 18, 2022

agones-bot commented Jun 20, 2022

agones-bot commented Jun 21, 2022

markmandel commented Jun 21, 2022

agones-bot commented Jun 30, 2022

markmandel commented Jul 3, 2022

agones-bot commented Jul 4, 2022

markmandel commented Jul 6, 2022

markmandel commented Jul 13, 2022

agones-bot commented Jul 15, 2022

agones-bot commented Jul 15, 2022

markmandel left a comment

Choose a reason for hiding this comment

google-oss-prow bot commented Jul 15, 2022