Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Katacoda link(404) because Katacoda is closed #2640

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Delete Katacoda link(404) because Katacoda is closed #2640

merged 2 commits into from
Jun 23, 2022

Conversation

govargo
Copy link
Contributor

@govargo govargo commented Jun 22, 2022

What type of PR is this?

/kind bug
/kind documentation

What this PR does / Why we need it:

When I ran make test, the htmltest failed with the following error.

Html Test: Attempt 1
htmltest started at 03:06:16 on /tmp/website
========================================================================
site/docs/prerequisite-knowledge/index.html
  Non-OK status: 404 --- site/docs/prerequisite-knowledge/index.html --> https://www.katacoda.com/courses/docker
  Non-OK status: 404 --- site/docs/prerequisite-knowledge/index.html --> https://www.katacoda.com/courses/kubernetes

Katacoda is now closed, so the link was 404.
In this PR, delete katacoda links.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

None

@govargo govargo changed the title Delete Katacoda link because Katacoda is closed Delete Katacoda link(404) because Katacoda is closed Jun 22, 2022
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 73eaff6a-71aa-40d0-85c7-4a80821531eb

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's so sad these resources are gone 😭

@markmandel
Copy link
Collaborator

Ah this ol' chestnut:

--- FAIL: TestFleetRollingUpdate (0.00s)
    --- FAIL: TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true (98.40s)
        fleet_test.go:413: 
            	Error Trace:	fleet_test.go:413
            	Error:      	Condition never satisfied
            	Test:       	TestFleetRollingUpdate/Use_fleet_Patch_true_25%_cycle_true
FAIL

(e2e-stable)

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f8708083-d42f-4a42-aab3-ba778d91acbe

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2640/head:pr_2640 && git checkout pr_2640
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-52d2f89-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: govargo, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot removed the lgtm label Jun 22, 2022
@google-oss-prow
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: e2152650-9e37-4e1d-807d-873ab26c34f7

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2640/head:pr_2640 && git checkout pr_2640
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.24.0-f7bb172-amd64

@markmandel markmandel merged commit 079dced into googleforgames:main Jun 23, 2022
@govargo govargo deleted the fix-404-katacoda branch June 30, 2022 13:11
@SaitejaTamma SaitejaTamma added kind/bug These are bugs. kind/documentation Documentation for Agones labels Jul 26, 2022
@SaitejaTamma SaitejaTamma added this to the 1.25.0 milestone Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved kind/bug These are bugs. kind/documentation Documentation for Agones size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants