Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Build: No more need for Docker 20 tag #2691

Merged

Conversation

markmandel
Copy link
Collaborator

What type of PR is this?

Uncomment only one /kind <> line, press enter to put that in a new line, and remove leading whitespace from that line:

/kind breaking
/kind bug

/kind cleanup

/kind documentation
/kind feature
/kind hotfix

What this PR does / Why we need it:

The default docker version in Cloud Build is now 20.x.x - so we no longer need to specify the tag, and can go back to using latest.

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

N/A

The default docker version in Cloud Build is now 20.x.x - so we no
longer need to specify the tag, and can go back to using latest.
@markmandel markmandel added kind/cleanup Refactoring code, fixing up documentation, etc area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. labels Jul 29, 2022
@markmandel markmandel requested a review from roberthbailey July 29, 2022 22:50
@google-oss-prow google-oss-prow bot requested a review from pooneh-m July 29, 2022 22:50
@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4248ff12-66c1-424a-b632-005cd0ca9438

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2452c36c-dd9d-4647-b1e5-e856d01229b5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2691/head:pr_2691 && git checkout pr_2691
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.25.0-a0d9f15-amd64

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: markmandel, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [markmandel,roberthbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c94215ba-e276-4a0e-a9f4-a3681041b03c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/googleforgames/agones.git pull/2691/head:pr_2691 && git checkout pr_2691
  • helm install agones ./install/helm/agones --namespace agones-system --set agones.image.tag=1.26.0-d54b779-amd64

@roberthbailey roberthbailey merged commit d206944 into googleforgames:main Aug 5, 2022
@markmandel markmandel deleted the build/no-docker-20-tag branch August 5, 2022 17:40
@SaitejaTamma SaitejaTamma added this to the 1.26.0 milestone Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc lgtm size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants